Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider changing the names of the native app base types (MauiWinUIApplication, MauiApplication, MauiUIApplicationDelegate) #2242

Closed
Eilon opened this issue Aug 25, 2021 · 5 comments
Labels
area-core-hosting Extensions / Hosting / AppBuilder / Startup proposal/open t/enhancement ☀️ New feature or request

Comments

@Eilon
Copy link
Member

Eilon commented Aug 25, 2021

These are the types in question for each platform:

Why change the names?

  • The names are not consistent with each other.
  • These type names are not usually seen by developers, so using up "good" names such as MauiApplication might be a "waste". These types are typically used once per project in a file generated by the project template (i.e. the user doesn't type it in)
  • This would mean "good" names such as MauiApplication could be used in more user-facing APIs that are more frequently worked on by developers, such as in the app's startup code (which, in my experience, changes quite a lot over time)

Why not change the names?

  • The name are consistent with the native base class names, which can be a benefit for someone familiar with the native architecture.
    • This doesn't preclude doing a rename, but perhaps the rename would be an "uglier" name that bears a resemblance to the native base class.
  • The names are consistent with Xamarin.Forms (somewhat)

Note: This originally came up in this PR (and subsequent discussion in the PR).

@jsuarezruiz
Copy link
Contributor

Already done in #2137

@Eilon
Copy link
Member Author

Eilon commented Oct 22, 2021

Not really done. This issue is a follow-up from that PR where we wanted to consider any further unification or non-unification.

@Eilon Eilon reopened this Oct 22, 2021
@jfversluis jfversluis added area-core-hosting Extensions / Hosting / AppBuilder / Startup proposal/open t/enhancement ☀️ New feature or request labels Nov 5, 2021
@rmarinho
Copy link
Member

We should figure this out before going GA . Should we schedule a call ?

@Eilon
Copy link
Member Author

Eilon commented Nov 12, 2021

@rmarinho yeah we could certainly do a call. I wonder does anyone have any proposals to share here, or any other thoughts on the pros/cons, or the "weights" of the pros/cons?

From my perspective, one of the biggest "weights" is to avoid "using up" a really good name such as MauiApplication for something that is almost never seen or interacted with directly by type name.

@jsuarezruiz jsuarezruiz added this to the .NET 7 milestone Nov 15, 2021
@Redth
Copy link
Member

Redth commented Nov 15, 2021

Considering the weight of this change to existing projects, we decided to leave it for NET6.

In .NET 7 we'll aim to do more source generation of these boilerplate implementations so these aren't as user facing. We can also consider obsoleting these in favour of a new name then (and making the obsolete ones subclass the new ones, and then remove them in net8).

@Redth Redth closed this as completed Nov 15, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Feb 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-core-hosting Extensions / Hosting / AppBuilder / Startup proposal/open t/enhancement ☀️ New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants