Fix Android Shell Navigation not properly waiting for end of transaction #26642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
PureWeen
reviewed
Dec 15, 2024
| @@ -19,11 +19,7 @@ public void FlyoutMenuShouldNotDisappearWhenNavigateUsingServices() | |||
| App.Tap("BackButton"); | |||
| App.WaitForElement("Login"); | |||
| App.Tap("Login"); | |||
| #if ANDROID | |||
There was a problem hiding this comment.
thank you for cleaning this one up!
PureWeen
approved these changes
Dec 15, 2024
PureWeen
approved these changes
Dec 15, 2024
|
albyrock87
added a commit
to nalu-development/maui-custom
that referenced
this pull request
Dec 16, 2024
…ion (dotnet#26642) * Fix Android Shell Navigation not properly waiting for end of transaction * Fixes other random failing tests on Android (cherry picked from commit f249086)
samhouts
added
the
fixed-in-net9.0-nightly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Android device test "Can reuse page" (Shell version) is failing on API >=33.
As we can see from the screenshot here, the end of the animation doesn't mean that the transaction has completed.
This simple change allows android to complete the last frame properly before engaging a new navigation.
I think this is positive even for
animtated: falsenavigations.This PR also fixes other randomly failing tests.
Issues Fixed
Fixes often broken device tests.