Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EvaluatedItemCheckData #10932

Merged
merged 2 commits into from
Nov 18, 2024
Merged

Add EvaluatedItemCheckData #10932

merged 2 commits into from
Nov 18, 2024

Conversation

JanKrivanek
Copy link
Member

@JanKrivanek JanKrivanek commented Nov 4, 2024

Context

Adding EvaluatedItemCheckData to BuildCheck OM - to prepare for some sample Item data/metadata Checks implementation

Testing

The leveraging checks:

@JanKrivanek JanKrivanek marked this pull request as ready for review November 8, 2024 10:14
@maridematte
Copy link
Contributor

Do we have plans to remove ParsedItemsCheckData in the future? Or are we just going to keep it as an obsolete class?

@JanKrivanek
Copy link
Member Author

Do we have plans to remove ParsedItemsCheckData in the future? Or are we just going to keep it as an obsolete class?

I'd give possible users at least 2 previews to use the new OM. So probably Feb/Mar next year - for 10.0, possibly for 9.0.3xx as well

@maridematte
Copy link
Contributor

I think adding some documentation or comment somewhere would interesting, so in the future we remember to remove the obsolete methods. Otherwise it might end-up like our Deprecated folder.

@JanKrivanek
Copy link
Member Author

I think adding some documentation or comment somewhere would interesting, so in the future we remember to remove the obsolete methods. Otherwise it might end-up like our Deprecated folder.

Definitely maes sense. Tracking here: #10985

@SimaTian SimaTian self-requested a review November 18, 2024 10:10
@JanKrivanek JanKrivanek merged commit eec6ac7 into main Nov 18, 2024
10 checks passed
@JanKrivanek JanKrivanek deleted the proto/buildcheck-itemdata branch November 18, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants