You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is mostly fixed, but I want to repurpose this issue to see if I can get rid of having a StringBuilder in the first place. If we just pass the parameters and items with metadata directly to the loggers (on the TaskStartedEventArgs presumably), then the loggers will not need to allocate the strings altogether, they'll write into their streams directly.
We can have the method that produces these strings on the Args in case the logger still wants the strings.
We'll need to think how to make this change backwards compatible, such that the loggers that are unaware of this change still get the exact same behavior as before.
But certainly I'd like to optimize this throughput for binary logger to minimize the allocation overhead.
See related:
#4907
This is really inefficient and allocates too much.
The text was updated successfully, but these errors were encountered: