-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move InitializeSourceRootMappedPaths targets down into common #5398
Comments
See also dotnet/fsharp#9379 |
These concepts don't apply to VC++ builds at all, do they? Of course, we have plenty of .NET stuff in common.targets already, but we do try to separate it out. I'd leave it in |
Do we need another layer of abstraction? (classic solution in computer science 😉) |
@rainersigwald, actually they do. Here is the documentation in the readme on Using Source Link in C++ projects. These targets should be moved to common. |
I'm not sure if VC++ compiler already supports path mapping but if not it is likely going to at some point to allow reproducible builds. So this logic would make sense for C++ project as well. |
There's an undocumented |
The targets for initializing
SourceRoot
items for deterministic builds lives in the Managed.core targets today. This means that other languages, like F#, need to copy the targets, which will lead to divergence and issues.https://github.com/dotnet/roslyn/blob/master/src/Compilers/Core/MSBuildTask/Microsoft.Managed.Core.targets#L158
We should move these targets down into the common targets so they're available to all languages as deterministic builds is a desirable, and encouraged, for published libraries and applications.
@tmat @cartermp @ctaggart
The text was updated successfully, but these errors were encountered: