Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WriteLinesToFile Does Not Support BOM Customization #6168

Open
benvillalobos opened this issue Feb 17, 2021 · 0 comments
Open

WriteLinesToFile Does Not Support BOM Customization #6168

benvillalobos opened this issue Feb 17, 2021 · 0 comments
Labels
help wanted Issues that the core team doesn't plan to work on, but would accept a PR for. Comment to claim. needs-design Requires discussion with the dev team before attempting a fix. triaged
Milestone

Comments

@benvillalobos
Copy link
Member

Context

The WriteLinesToFile task uses UTF-8 encoding without BOM (byte order mark) by default. This is not specified in the documentation and could be useful to have control over.

The difficulty is allowing control over the optional Encoding parameter and control over the BOM without adding a special case for every single encoding.

Some options I sent in the internal thread that started this issue:

  1. We pick a few encodings that are most common/popular/etc. and special case those and no others.
  2. We can pass an optional parameter to override whether s_defaultEncoding applies a BOM.

Let's discuss what potential solutions there are before implementing an improvement.

@benvillalobos benvillalobos added help wanted Issues that the core team doesn't plan to work on, but would accept a PR for. Comment to claim. needs-design Requires discussion with the dev team before attempting a fix. labels Feb 17, 2021
@benvillalobos benvillalobos added this to the Backlog milestone Feb 17, 2021
@JaynieBai JaynieBai assigned JaynieBai and unassigned JaynieBai Feb 13, 2023
@AR-May AR-May added the triaged label Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Issues that the core team doesn't plan to work on, but would accept a PR for. Comment to claim. needs-design Requires discussion with the dev team before attempting a fix. triaged
Projects
None yet
Development

No branches or pull requests

3 participants