Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Flaky test] Microsoft.Build.Tasks.UnitTests.SecurityUtil_Tests.SignFile_Success #9639

Closed
surayya-MS opened this issue Jan 12, 2024 · 4 comments
Assignees
Labels
Area: Our Own Build Problems affecting the build or build infrastructure of the MSBuild repo itself. flaky-test Tests that have failed but passed on rerun. Priority:2 Work that is important, but not critical for the release triaged

Comments

@surayya-MS
Copy link
Member

While working on #9621 I came across this flaky test. It flakes quite often.

There are no error message or stack trace.

Sample failing build:
https://dev.azure.com/dnceng-public/public/_build/results?buildId=521905&view=ms.vss-test-web.build-test-results-tab&runId=12263180&resultId=104535&paneView=history

@surayya-MS surayya-MS added Area: Our Own Build Problems affecting the build or build infrastructure of the MSBuild repo itself. flaky-test Tests that have failed but passed on rerun. labels Jan 12, 2024
@JaynieBai JaynieBai self-assigned this Jan 16, 2024
@AR-May AR-May added Priority:2 Work that is important, but not critical for the release triaged labels Jan 16, 2024
@JanKrivanek
Copy link
Member

@surayya-MS pointed aother recently failing instance: https://dev.azure.com/dnceng-public/public/_build/results?buildId=535267&view=ms.vss-test-web.build-test-results-tab

Looking into artifacts, this is what is in the test artifacts (Microsoft.Build.Tasks.UnitTests_net472_x86.xml):

Shouldly.ShouldAssertException : `SignAction`\r\n    should not throw but threw\r\nSystem.ApplicationException\r\n    with message\r\n\"The parameter is incorrect.\r\n\"
   at Microsoft.Build.Tasks.UnitTests.SecurityUtil_Tests.SignFile_Success(String tfVersion, String tfIdentifier) in D:\a\1\s\src\Tasks.UnitTests\SecurityUtil_Tests.cs:line 48

@YuliiaKovalova
Copy link
Member

Please check the recent runs: https://dev.azure.com/dnceng-public/public/_build?definitionId=75

@YuliiaKovalova
Copy link
Member

It seems like the recent runs are green.
Can we close it?

@surayya-MS
Copy link
Member Author

It seems like the recent runs are green. Can we close it?

If that's the case, I think we should close it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Our Own Build Problems affecting the build or build infrastructure of the MSBuild repo itself. flaky-test Tests that have failed but passed on rerun. Priority:2 Work that is important, but not critical for the release triaged
Projects
None yet
Development

No branches or pull requests

5 participants