Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't stomp on CreateSatelliteAssembliesDependsOn property in the common targets #9703

Closed
baronfel opened this issue Feb 1, 2024 · 3 comments · Fixed by #9704
Closed

Don't stomp on CreateSatelliteAssembliesDependsOn property in the common targets #9703

baronfel opened this issue Feb 1, 2024 · 3 comments · Fixed by #9704
Assignees
Labels

Comments

@baronfel
Copy link
Member

baronfel commented Feb 1, 2024

We missed this one in #4922, currently the CreateSatelliteAssembliesDependsOn definition isn't extendable by users in their project files, so they have to reach for mechanisms like Directory.Build.targets to ensure they can extend the process.

@JanKrivanek
Copy link
Member

This actually seems to be much more widespread - e.g. the externally documented Commonly overridden DependsOn properties

But there are others then seem as potentially usefull - CoreBuildDependsOn, RebuildDependsOn, RunDependsOn, PublishDependsOn etc. etc.

So the questions is - do we want to generally open this? Or any of them? Or do we want to keep them as-is semi-hidden, overridable only via explicit importing of sdk.targets?

cc @baronfel

@baronfel
Copy link
Member Author

Oof. IMO we should open these as #4922 intended.

@JanKrivanek
Copy link
Member

#9755

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants