Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve pluralization of terms for summaries in the product #9921

Open
AR-May opened this issue Mar 25, 2024 · 1 comment
Open

Improve pluralization of terms for summaries in the product #9921

AR-May opened this issue Mar 25, 2024 · 1 comment
Labels
Area: Terminal Logger Problems with the livelogger/fancylogger/terminallogger -tl functionality. Priority:3 Work that is nice to have triaged

Comments

@AR-May
Copy link
Member

AR-May commented Mar 25, 2024

In every case when we say warning(s) or error(s) we know if the quantity is plural or not, so we should just pluralize the noun correctly - both on this final-build summary and on the per-project summaries.

See discussion in the PR.

In short, the current RESX-based localization method makes it very hard to report pluralized and singular terms for values without a large amount of developer overhead. This desired error report summary is one example, and in #9929 @nohwnd and I were discussing the same problem - reporting singular and plural forms of successes, failures, and skipped tests leads to an explosion of terms in order to support different language grammars and layout.

We need a system that doesn't impose so much burden on developers.

@AR-May AR-May added Priority:3 Work that is nice to have triaged Area: Terminal Logger Problems with the livelogger/fancylogger/terminallogger -tl functionality. labels Mar 26, 2024
@baronfel baronfel changed the title Improve Terminal Logger summaries' messages. Improve pluralization of terms for summaries in the product Mar 26, 2024
@nohwnd
Copy link
Member

nohwnd commented Mar 27, 2024

As an example a simple summary of a test run:

In english we need 2 variations:

Ran 0 tests
Ran 1 test

In czech we need 3 variations.

Spuštěno 0 testů
Spuštěn 1 test
Spuštěny 2 testy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Terminal Logger Problems with the livelogger/fancylogger/terminallogger -tl functionality. Priority:3 Work that is nice to have triaged
Projects
None yet
Development

No branches or pull requests

2 participants