-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add e2e test for custom analyzer rules #10076
Add e2e test for custom analyzer rules #10076
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the idea of having a full-strength end-to-end-via-package test, but it feels very early for that to be checked in, and the package construction stuff is low-pri for me. Is now the right time?
src/BuildCheck.UnitTests/TestAssets/CustomAnalyzer/CustomAnalyzer.csproj
Outdated
Show resolved
Hide resolved
src/BuildCheck.UnitTests/TestAssets/CustomAnalyzer/CustomAnalyzer.csproj
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for tackling this!
src/BuildCheck.UnitTests/TestAssets/CustomAnalyzer/CustomAnalyzer.csproj
Show resolved
Hide resolved
src/BuildCheck.UnitTests/TestAssets/CustomAnalyzer/CustomAnalyzer.csproj
Outdated
Show resolved
Hide resolved
Let's discuss the concerns offline (@YuliiaKovalova, @rainersigwald) - I want to understand them better |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool tests! :) Thank you!
Context
In order to cover the full flow, in this tests we:
The structure of the rules was generated using: https://github.com/dotnet/msbuild/tree/main/template_feed/Microsoft.AnalyzerTemplate