-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get the windows kits root from the registry value "HKLM\SOFTWARE\Microsoft\Windows Kits\Installed Roots" @KitsRoot10 #8745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JaynieBai
changed the title
Jennybai/issue6090
Get the windows kits root from the registry value "HKLM\SOFTWARE\Microsoft\Windows Kits\Installed Roots" @KitsRoot10
May 10, 2023
AFAIK Also, reserving the |
YuliiaKovalova
approved these changes
Apr 2, 2024
surayya-MS
approved these changes
Apr 8, 2024
@YuliiaKovalova, do yo think this PR can be merged? |
rainersigwald
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6090
Context
See here:
msbuild/src/Tasks/Microsoft.Common.CurrentVersion.targets
Line 2348 in ec6ed83
It's always looking for the Win10 SDK root under program files ($(MSBuildProgramFiles32)\Windows Kits\10). It should instead get the root from the registry value "HKLM\SOFTWARE\Microsoft\Windows Kits\Installed Roots" @KitsRoot10
Changes Made
Get the root from the registry value "HKLM\SOFTWARE\Microsoft\Windows Kits\Installed Roots" @KitsRoot10 with $([MSBuild]::GetRegistryValueFromView('HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Windows Kits\Installed Roots', 'KitsRoot10', null, RegistryView.Registry32, RegistryView.Default))
Testing
Couldn't install the windows SDK10 in non-default driver in the pipeline machine. So, test it locally.
Notes