-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Keep the encoding of standard output & error consistent with the console code page #9539
Conversation
Hello! I noticed that you're targeting one of our servicing branches. Please consider updating the version. |
c4fd4ee
to
3e29a5a
Compare
3e29a5a
to
c6b96b8
Compare
This doesn't seem like a bad change, and I haven't checked whether it actually fixes the bug or not. It looks like I looked at this bug over two years ago and thought the problem may have been because the Message task didn't support changing the code page directly and may have been that the user needed to change how they were using a ToolTask. Assuming this does fix the problem, though this sounds like a positive change, I'd say it suggests the problem should have been fixed by whoever implemented the ToolTask that is ultimately broken; all they would've had to do is set that property as you did here except in their ToolTask extension. In fact, I'd argue that's a better fix, as this one changes fairly fundamental behavior in MSBuild, which always has potential to cause someone issues even if the change looks benign. Just my 2c 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please try to see if we can can move the logic to property initialization.
If not - let's discuss other alternatives
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1388756/
Context
With OS language English and VS language JPN, building newly created CMake project named
プロジェクト
got garbage characters in the output.Changes Made
Make the encoding of process standard output & error consistent with the console code page.
Testing
Added unit tests.
Notes