Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix [DebuggerDisplay] for Microsoft.Build.Evaluation.Project #9738

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

eterekhin
Copy link
Contributor

Hey! Looks like the DebuggerDisplayAttribute didn't work since there's no _data field on ProjectLink abstract type

Copy link
Member

@rainersigwald rainersigwald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (but I didn't actually look at it in the debugger to double-check).

Thanks!

Copy link
Member

@ladipro ladipro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great, thank you.

@eterekhin
Copy link
Contributor Author

eterekhin commented Feb 22, 2024

@rainersigwald, @ladipro, Hello! Thanks for the review! Seems like I can't merge into the main for some reason. May I ask you to press a "Merge" button?
image

@ladipro ladipro merged commit cdcfc35 into dotnet:main Feb 22, 2024
8 checks passed
@ladipro
Copy link
Member

ladipro commented Feb 22, 2024

@eterekhin, done.

@eterekhin eterekhin deleted the debugger-display-fix branch February 22, 2024 14:39
maridematte pushed a commit to maridematte/msbuild that referenced this pull request Feb 26, 2024
…9738)

Looks like the DebuggerDisplayAttribute didn't work since there's no ``_data`` field on ``ProjectLink`` abstract type.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants