Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use templates-official for production pipeline + @self #9836

Merged

Conversation

YuliiaKovalova
Copy link
Member

@YuliiaKovalova YuliiaKovalova commented Mar 7, 2024

Context

We need to adapt official templates for production pipelines

Note

There is a warning on sbom generation - it will be resolved on the servicing side in scope of
dotnet/arcade#14560

Testing

Yes, by using exp branch: https://tfsprodwus2su6.visualstudio.com/A011b8bdf-6d56-4f87-be0d-0092136884d9/DevDiv/_build/results?buildId=9236625&view=results

@YuliiaKovalova YuliiaKovalova changed the title use templates-official for production pipeline + @self Use templates-official for production pipeline + @self Mar 7, 2024
@YuliiaKovalova YuliiaKovalova marked this pull request as ready for review March 13, 2024 09:48
@YuliiaKovalova YuliiaKovalova requested a review from a team as a code owner March 13, 2024 09:48
@YuliiaKovalova
Copy link
Member Author

@rainersigwald could you invite someone from 1es team for reviewing it? Thank you!

Copy link
Member

@rainersigwald rainersigwald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rainersigwald could you invite someone from 1es team for reviewing it? Thank you!

I don't think there's a need for 1ES review. We could maybe ask an Arcade person but honestly I think we're good to go.

.vsts-dotnet.yml Outdated Show resolved Hide resolved
Co-authored-by: Rainer Sigwald <raines@microsoft.com>
@YuliiaKovalova YuliiaKovalova merged commit a7c9b75 into dotnet:main Mar 14, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants