Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial version of Analyzers specs #9853

Merged
merged 25 commits into from
Apr 11, 2024
Merged

Conversation

JanKrivanek
Copy link
Member

@JanKrivanek JanKrivanek commented Mar 12, 2024

Fixes #9895

Context

Initial draft of specs (external and internal design) fpr Analyzers (AKA BuildCheck) feature.
Should as well serve as supportive materials for reviewing #9735

documentation/specs/proposed/BuildCheck.md Outdated Show resolved Hide resolved
documentation/specs/proposed/BuildCheck.md Outdated Show resolved Hide resolved
documentation/specs/proposed/BuildCheck.md Show resolved Hide resolved
documentation/specs/proposed/BuildCheck.md Show resolved Hide resolved
documentation/specs/proposed/BuildCheck.md Outdated Show resolved Hide resolved
documentation/specs/proposed/BuildCheck.md Outdated Show resolved Hide resolved
documentation/specs/proposed/BuildCheck.md Show resolved Hide resolved
documentation/specs/proposed/BuildCheck.md Outdated Show resolved Hide resolved
Copy link
Member

@rainersigwald rainersigwald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First round comments, BuildCheck.md only

documentation/specs/proposed/BuildCheck.md Outdated Show resolved Hide resolved
documentation/specs/proposed/BuildCheck.md Outdated Show resolved Hide resolved
documentation/specs/proposed/BuildCheck.md Outdated Show resolved Hide resolved
documentation/specs/proposed/BuildCheck.md Outdated Show resolved Hide resolved
documentation/specs/proposed/BuildCheck.md Show resolved Hide resolved
documentation/specs/proposed/BuildCheck.md Outdated Show resolved Hide resolved
documentation/specs/proposed/BuildCheck.md Outdated Show resolved Hide resolved
documentation/specs/proposed/BuildCheck.md Outdated Show resolved Hide resolved
documentation/specs/proposed/BuildCheck.md Outdated Show resolved Hide resolved
documentation/specs/proposed/BuildCheck.md Show resolved Hide resolved
JanKrivanek and others added 2 commits March 15, 2024 20:32
Co-authored-by: Rainer Sigwald <raines@microsoft.com>
Co-authored-by: Chet Husk <baronfel@users.noreply.github.com>
Copy link
Member

@rainersigwald rainersigwald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Architecture doc comments.

Copy link
Member

@rainersigwald rainersigwald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Architecture doc comments.

documentation/specs/proposed/BuildCheck.md Outdated Show resolved Hide resolved
documentation/specs/proposed/BuildCheck.md Outdated Show resolved Hide resolved
documentation/specs/proposed/BuildCheck-Architecture.md Outdated Show resolved Hide resolved
@JanKrivanek JanKrivanek changed the title Initial draft of Analyzers specs Initial version of Analyzers specs Mar 18, 2024
@JanKrivanek JanKrivanek marked this pull request as ready for review March 18, 2024 16:02
documentation/specs/proposed/BuildCheck-Architecture.md Outdated Show resolved Hide resolved
documentation/specs/proposed/BuildCheck-Architecture.md Outdated Show resolved Hide resolved
documentation/specs/proposed/BuildCheck-Architecture.md Outdated Show resolved Hide resolved
documentation/specs/proposed/BuildCheck-Architecture.md Outdated Show resolved Hide resolved
documentation/specs/proposed/BuildCheck.md Outdated Show resolved Hide resolved
documentation/specs/proposed/BuildCheck.md Outdated Show resolved Hide resolved
documentation/specs/proposed/BuildCheck.md Outdated Show resolved Hide resolved
documentation/specs/proposed/BuildCheck.md Outdated Show resolved Hide resolved
documentation/specs/proposed/BuildCheck.md Outdated Show resolved Hide resolved
documentation/specs/proposed/BuildCheck-Architecture.md Outdated Show resolved Hide resolved
documentation/specs/proposed/BuildCheck-Architecture.md Outdated Show resolved Hide resolved
documentation/specs/proposed/BuildCheck-Architecture.md Outdated Show resolved Hide resolved
documentation/specs/proposed/BuildCheck-Architecture.md Outdated Show resolved Hide resolved
documentation/specs/proposed/BuildCheck.md Outdated Show resolved Hide resolved
documentation/specs/proposed/BuildCheck.md Outdated Show resolved Hide resolved
documentation/specs/proposed/BuildCheck.md Show resolved Hide resolved
Copy link
Member

@YuliiaKovalova YuliiaKovalova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
It looks great.

@JanKrivanek
Copy link
Member Author

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Co-authored-by: Roman Konecny <rokonecn@microsoft.com>
@JanKrivanek JanKrivanek merged commit 1d859ad into dotnet:main Apr 11, 2024
9 checks passed
@JanKrivanek JanKrivanek deleted the doc/analyzers branch April 11, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Write and get a sign-off for a BuildCheck design doc
8 participants