Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Perf] Linux/x64: 1 Regression on 5/27/2023 6:38:16 PM #18346

Open
performanceautofiler bot opened this issue May 30, 2023 · 1 comment
Open

[Perf] Linux/x64: 1 Regression on 5/27/2023 6:38:16 PM #18346

performanceautofiler bot opened this issue May 30, 2023 · 1 comment

Comments

@performanceautofiler
Copy link

performanceautofiler bot commented May 30, 2023

Run Information

Name Value
Architecture x64
OS ubuntu 18.04
Queue TigerUbuntu
Baseline 71738239969b184b66e72a927a527690a761ecbf
Compare 5b8437d9f9e410bf672bb62d5371fdeb8931e5f1
Diff Diff
Configs AOT:true, CompilationMode:wasm, RunKind:micro

Regressions in GuardedDevirtualization.TwoClassInterface

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio Baseline ETL Compare ETL
Call - Duration of single invocation 11.56 ns 13.06 ns 1.13 0.33 False

graph
Test Report

Repro

General Docs link: https://github.com/dotnet/performance/blob/main/docs/benchmarking-workflow-dotnet-runtime.md

Payloads

Baseline
Compare

git clone https://github.com/dotnet/performance.git
python3 .\performance\scripts\benchmarks_ci.py -f net8.0 --filter 'GuardedDevirtualization.TwoClassInterface*'

Payloads

Baseline
Compare

Histogram

GuardedDevirtualization.TwoClassInterface.Call(testInput: pB = 0.30)


Description of detection logic

IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 13.057826643125898 > 12.078385472679145.
IsChangePoint: Marked as a change because one of 5/27/2023 2:31:56 PM, 5/29/2023 10:47:10 AM falls between 5/20/2023 9:58:12 PM and 5/29/2023 10:47:10 AM.
IsRegressionStdDev: Marked as regression because -3.4564655916787013 (T) = (0 -13.521222283033143) / Math.Sqrt((0.3820243415941902 / (42)) + (0.4294710381700897 / (2))) is less than -2.0180817028167235 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (42) + (2) - 2, .025) and -0.1375812153974639 = (11.885940186089405 - 13.521222283033143) / 11.885940186089405 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

JIT Disasms

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

@radekdoulik
Copy link
Member

this might be dotnet/runtime#86835, not sure how it would affect wasm though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant