Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Perf] Linux/x64: 8 Improvements on 7/10/2024 10:56:31 PM #38616

Open
performanceautofiler bot opened this issue Jul 18, 2024 · 4 comments
Open

[Perf] Linux/x64: 8 Improvements on 7/10/2024 10:56:31 PM #38616

performanceautofiler bot opened this issue Jul 18, 2024 · 4 comments

Comments

@performanceautofiler
Copy link

Run Information

Name Value
Architecture x64
OS ubuntu 22.04
Queue TigerUbuntu
Baseline 4a1a07666b55ed425a5c43896e7869227fca500c
Compare 8ba8249272917366e2382bb4c67a2347d19d2fb6
Diff Diff
Configs AOT:true, CompilationMode:wasm, RunKind:micro

Improvements in System.Numerics.Tensors.Tests.Perf_FloatingPointTensorPrimitives<Double>

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio
21.83 μs 11.79 μs 0.54 0.11 True
6.27 μs 1.39 μs 0.22 0.08 False
279.20 ns 75.99 ns 0.27 0.13 False
24.34 μs 11.68 μs 0.48 0.22 True
531.06 μs 287.22 μs 0.54 0.13 True
555.30 μs 285.33 μs 0.51 0.20 True

graph
graph
graph
graph
graph
graph
Test Report

Repro

General Docs link: https://github.com/dotnet/performance/blob/main/docs/benchmarking-workflow-dotnet-runtime.md

git clone https://github.com/dotnet/performance.git
python3 .\performance\scripts\benchmarks_ci.py -f net8.0 --filter 'System.Numerics.Tensors.Tests.Perf_FloatingPointTensorPrimitives&lt;Double&gt;*'

System.Numerics.Tensors.Tests.Perf_FloatingPointTensorPrimitives<Double>.Round(BufferLength: 128)

ETL Files

Histogram

JIT Disasms

System.Numerics.Tensors.Tests.Perf_FloatingPointTensorPrimitives<Double>.CosineSimilarity(BufferLength: 3079)

ETL Files

Histogram

JIT Disasms

System.Numerics.Tensors.Tests.Perf_FloatingPointTensorPrimitives<Double>.CosineSimilarity(BufferLength: 128)

ETL Files

Histogram

JIT Disasms

System.Numerics.Tensors.Tests.Perf_FloatingPointTensorPrimitives<Double>.Truncate(BufferLength: 128)

ETL Files

Histogram

JIT Disasms

System.Numerics.Tensors.Tests.Perf_FloatingPointTensorPrimitives<Double>.Round(BufferLength: 3079)

ETL Files

Histogram

JIT Disasms

System.Numerics.Tensors.Tests.Perf_FloatingPointTensorPrimitives<Double>.Truncate(BufferLength: 3079)

ETL Files

Histogram

JIT Disasms

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository


Run Information

Name Value
Architecture x64
OS ubuntu 22.04
Queue TigerUbuntu
Baseline 4a1a07666b55ed425a5c43896e7869227fca500c
Compare 8ba8249272917366e2382bb4c67a2347d19d2fb6
Diff Diff
Configs AOT:true, CompilationMode:wasm, RunKind:micro

Improvements in System.Numerics.Tensors.Tests.Perf_FloatingPointTensorPrimitives<Single>

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio
14.76 μs 6.03 μs 0.41 0.15 True
367.97 μs 137.70 μs 0.37 0.18 True

graph
graph
Test Report

Repro

General Docs link: https://github.com/dotnet/performance/blob/main/docs/benchmarking-workflow-dotnet-runtime.md

git clone https://github.com/dotnet/performance.git
python3 .\performance\scripts\benchmarks_ci.py -f net8.0 --filter 'System.Numerics.Tensors.Tests.Perf_FloatingPointTensorPrimitives&lt;Single&gt;*'

System.Numerics.Tensors.Tests.Perf_FloatingPointTensorPrimitives<Single>.Truncate(BufferLength: 128)

ETL Files

Histogram

JIT Disasms

System.Numerics.Tensors.Tests.Perf_FloatingPointTensorPrimitives<Single>.Truncate(BufferLength: 3079)

ETL Files

Histogram

JIT Disasms

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

@lewing
Copy link
Member

lewing commented Jul 19, 2024

Probably from dotnet/runtime#104651 cc @stephentoub

@stephentoub
Copy link
Member

Probably from dotnet/runtime#104651 cc @stephentoub

While I appreciate the credit, this is very unlikely; that PR only added new API and didn't touch any existing implementation.

@lewing
Copy link
Member

lewing commented Jul 19, 2024

Probably from dotnet/runtime#104651 cc @stephentoub

While I appreciate the credit, this is very unlikely; that PR only added new API and didn't touch any existing implementation.

range was off in the diff dotnet/runtime@5795e8c...4a1a076 -> dotnet/runtime#103837 for this and a couple of other issue... very odd

@stephentoub
Copy link
Member

dotnet/runtime#103837

Yeah, that makes much more sense. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants