Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Perf] Linux/x64: 3 Regressions on 10/17/2022 3:19:47 PM #9223

Closed
performanceautofiler bot opened this issue Oct 25, 2022 · 3 comments
Closed

[Perf] Linux/x64: 3 Regressions on 10/17/2022 3:19:47 PM #9223

performanceautofiler bot opened this issue Oct 25, 2022 · 3 comments

Comments

@performanceautofiler
Copy link

performanceautofiler bot commented Oct 25, 2022

Run Information

Architecture x64
OS ubuntu 18.04
Baseline 6dc9a74481888a13573d90424d06484bbf425b4a
Compare 3ba1dd21d91ddbe97dc571e45dc608610660c4f3
Diff Diff

Regressions in System.Text.Json.Serialization.Tests.ColdStartSerialization<SimpleStructWithProperties>

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio Baseline ETL Compare ETL
NewDefaultOptions - Duration of single invocation 40.55 μs 47.20 μs 1.16 0.01 False
NewCachedCustomConverter - Duration of single invocation 50.06 μs 55.26 μs 1.10 0.01 False
NewCustomizedOptions - Duration of single invocation 48.00 μs 53.77 μs 1.12 0.01 False

graph
graph
graph
Test Report

Repro

git clone https://github.com/dotnet/performance.git
python3 .\performance\scripts\benchmarks_ci.py -f net6.0 --filter 'System.Text.Json.Serialization.Tests.ColdStartSerialization&lt;SimpleStructWithProperties&gt;*'

Related Issues

Regressions

Improvements

Payloads

Baseline
Compare

Histogram

Edge Detector Info

Collection Data

System.Text.Json.Serialization.Tests.ColdStartSerialization<SimpleStructWithProperties>.NewDefaultOptions


Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionWindowed: Marked as regression because 47.195356262550206 > 42.52726250243507.
IsChangePoint: Marked as a change because one of 10/6/2022 12:41:43 AM, 10/17/2022 12:47:34 PM, 10/25/2022 8:17:52 AM falls between 10/16/2022 1:15:28 PM and 10/25/2022 8:17:52 AM.
IsRegressionStdDev: Marked as regression because -72.64660634080485 (T) = (0 -47347.320810676574) / Math.Sqrt((44330.82566612571 / (15)) + (174775.89094378593 / (29))) is less than -2.0180817028167235 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (15) + (29) - 2, .025) and -0.17015893716837666 = (40462.29901491037 - 47347.320810676574) / 40462.29901491037 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

```#### System.Text.Json.Serialization.Tests.ColdStartSerialization&lt;SimpleStructWithProperties&gt;.NewCachedCustomConverter

```log

Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionWindowed: Marked as regression because 55.25684734049314 > 52.22794247551497.
IsChangePoint: Marked as a change because one of 10/6/2022 12:41:43 AM, 10/17/2022 12:47:34 PM, 10/25/2022 8:17:52 AM falls between 10/16/2022 1:15:28 PM and 10/25/2022 8:17:52 AM.
IsRegressionStdDev: Marked as regression because -48.87951215137908 (T) = (0 -55296.492607043714) / Math.Sqrt((81018.99696762237 / (14)) + (222621.616730214 / (29))) is less than -2.019540970439573 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (14) + (29) - 2, .025) and -0.11429033632478773 = (49624.85162477993 - 55296.492607043714) / 49624.85162477993 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

```#### System.Text.Json.Serialization.Tests.ColdStartSerialization&lt;SimpleStructWithProperties&gt;.NewCustomizedOptions

```log

Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionWindowed: Marked as regression because 53.76983099942726 > 50.27785346319281.
IsChangePoint: Marked as a change because one of 10/6/2022 12:41:43 AM, 10/17/2022 12:47:34 PM, 10/25/2022 8:17:52 AM falls between 10/16/2022 1:15:28 PM and 10/25/2022 8:17:52 AM.
IsRegressionStdDev: Marked as regression because -51.877665914827055 (T) = (0 -53933.22996125165) / Math.Sqrt((111712.93352331268 / (15)) + (175345.1021053672 / (29))) is less than -2.0180817028167235 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (15) + (29) - 2, .025) and -0.12579136949602 = (47906.949211554 - 53933.22996125165) / 47906.949211554 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

@radekdoulik
Copy link
Member

This is caused by dotnet/runtime#76607. @eiriktsarpalis please take a look. I see it is also causing regressions on window/intel measurements.

@eiriktsarpalis
Copy link
Member

eiriktsarpalis commented Nov 2, 2022

I believe it's actually caused by dotnet/runtime#76782 and is a duplicate of dotnet/runtime#77279 and #9056. We can close this as by-design.

I don't have permissions in this repo to close it myself, unfortunately.

@radekdoulik
Copy link
Member

Indeed dotnet/runtime#76782. Thanks for looking into that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants