Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Perf] Linux/x64: 8 Regressions on 10/18/2022 8:25:03 PM #9225

Closed
performanceautofiler bot opened this issue Oct 25, 2022 · 3 comments
Closed

[Perf] Linux/x64: 8 Regressions on 10/18/2022 8:25:03 PM #9225

performanceautofiler bot opened this issue Oct 25, 2022 · 3 comments
Assignees
@kotlarmilos
Labels
arch-wasm arch-x64 branch-refs/heads/main kind-micro os-linux perf-regression

Comments

@performanceautofiler
Copy link

performanceautofiler bot commented Oct 25, 2022 •
edited
Loading

Run Information

Architecture x64
OS ubuntu 18.04
Baseline e8fa4a736d6bdcfbbe2c2dc1dd1303214bb97085
Compare 51e3afb2ba42609c3711cb50fb5eaa6800bc1fde
Diff Diff

Regressions in System.Reflection.Invoke

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio Baseline ETL Compare ETL
Property_Get_int - Duration of single invocation 151.18 ns 167.54 ns 1.11 0.08 False

graph
Test Report

Repro

git clone https://github.com/dotnet/performance.git
python3 .\performance\scripts\benchmarks_ci.py -f net6.0 --filter 'System.Reflection.Invoke*'

Related Issues

Regressions

Improvements

Payloads

Baseline
Compare

Histogram

Edge Detector Info

Collection Data

System.Reflection.Invoke.Property_Get_int

Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionWindowed: Marked as regression because 167.5409131648936 > 161.5647779467535.
IsChangePoint: Marked as a change because one of 10/18/2022 9:26:37 AM, 10/25/2022 8:17:52 AM falls between 10/16/2022 1:15:28 PM and 10/25/2022 8:17:52 AM.
IsRegressionStdDev: Marked as regression because -16.563157643435478 (T) = (0 -167.7036824037614) / Math.Sqrt((10.107918978764326 / (20)) + (4.3445344951992615 / (22))) is less than -2.0210753903043583 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (20) + (22) - 2, .025) and -0.09027683040657852 = (153.81752388631656 - 167.7036824037614) / 153.81752388631656 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

### Run Information
Architecture x64
OS ubuntu 18.04
Baseline e8fa4a736d6bdcfbbe2c2dc1dd1303214bb97085
Compare 51e3afb2ba42609c3711cb50fb5eaa6800bc1fde
Diff Diff

Regressions in System.IO.Tests.Perf_File

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio Baseline ETL Compare ETL
CopyToOverwrite - Duration of single invocation 44.64 μs 52.66 μs 1.18 0.06 False
CopyTo - Duration of single invocation 61.93 μs 73.15 μs 1.18 0.03 False
ReadAllBytes - Duration of single invocation 23.22 μs 28.24 μs 1.22 0.07 False
CopyTo - Duration of single invocation 61.27 μs 73.20 μs 1.19 0.06 False
CopyToOverwrite - Duration of single invocation 44.85 μs 52.71 μs 1.18 0.06 False
ReadAllBytes - Duration of single invocation 23.39 μs 27.96 μs 1.20 0.06 False
ReadAllBytes - Duration of single invocation 28.83 μs 33.22 μs 1.15 0.04 False

graph
graph
graph
graph
graph
graph
graph
Test Report

Repro

git clone https://github.com/dotnet/performance.git
python3 .\performance\scripts\benchmarks_ci.py -f net6.0 --filter 'System.IO.Tests.Perf_File*'

Related Issues

Regressions

Improvements

Payloads

Baseline
Compare

Histogram

Edge Detector Info

Collection Data

System.IO.Tests.Perf_File.CopyToOverwrite(size: 4096)

Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionWindowed: Marked as regression because 52.66381797052155 > 46.85190000625001.
IsChangePoint: Marked as a change because one of 9/7/2022 8:46:47 AM, 10/18/2022 9:26:37 AM, 10/25/2022 8:17:52 AM falls between 10/16/2022 1:15:28 PM and 10/25/2022 8:17:52 AM.
IsRegressionStdDev: Marked as regression because -32.58185557054538 (T) = (0 -53241.60259280379) / Math.Sqrt((483151.07658197335 / (19)) + (975456.8907339427 / (24))) is less than -2.019540970439573 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (19) + (24) - 2, .025) and -0.18666606175429587 = (44866.541909941036 - 53241.60259280379) / 44866.541909941036 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

```#### System.IO.Tests.Perf_File.CopyTo(size: 4096)

```log

Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionWindowed: Marked as regression because 73.14544594961242 > 64.76320662507332.
IsChangePoint: Marked as a change because one of 9/7/2022 8:46:47 AM, 10/18/2022 9:26:37 AM, 10/25/2022 8:17:52 AM falls between 10/16/2022 1:15:28 PM and 10/25/2022 8:17:52 AM.
IsRegressionStdDev: Marked as regression because -36.43303765170729 (T) = (0 -73209.82793268189) / Math.Sqrt((856894.7252116846 / (20)) + (1241626.0167246251 / (23))) is less than -2.019540970439573 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (20) + (23) - 2, .025) and -0.18323006777726247 = (61872.85966304847 - 73209.82793268189) / 61872.85966304847 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

```#### System.IO.Tests.Perf_File.ReadAllBytes(size: 4096)

```log

Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionWindowed: Marked as regression because 28.241726838456906 > 24.407974539891633.
IsChangePoint: Marked as a change because one of 9/7/2022 8:46:47 AM, 9/26/2022 7:45:50 PM, 10/18/2022 9:26:37 AM, 10/25/2022 8:17:52 AM falls between 10/16/2022 1:15:28 PM and 10/25/2022 8:17:52 AM.
IsRegressionStdDev: Marked as regression because -45.8504449901641 (T) = (0 -28378.828754703653) / Math.Sqrt((76282.84221415715 / (20)) + (203122.3050767671 / (23))) is less than -2.019540970439573 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (20) + (23) - 2, .025) and -0.2220225661069876 = (23222.83527472855 - 28378.828754703653) / 23222.83527472855 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

```#### System.IO.Tests.Perf_File.CopyTo(size: 512)

```log

Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionWindowed: Marked as regression because 73.19719659267912 > 64.55266545840088.
IsChangePoint: Marked as a change because one of 9/7/2022 8:46:47 AM, 10/18/2022 9:26:37 AM, 10/25/2022 8:17:52 AM falls between 10/16/2022 1:15:28 PM and 10/25/2022 8:17:52 AM.
IsRegressionStdDev: Marked as regression because -35.86162989155517 (T) = (0 -73166.82726786066) / Math.Sqrt((1071344.9548346074 / (19)) + (1029936.253049924 / (22))) is less than -2.0226909200346674 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (19) + (22) - 2, .025) and -0.1868818136873732 = (61646.262015379514 - 73166.82726786066) / 61646.262015379514 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

```#### System.IO.Tests.Perf_File.CopyToOverwrite(size: 512)

```log

Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionWindowed: Marked as regression because 52.713447723671386 > 47.271385468648496.
IsChangePoint: Marked as a change because one of 9/7/2022 8:46:47 AM, 10/18/2022 9:26:37 AM, 10/25/2022 8:17:52 AM falls between 10/16/2022 1:15:28 PM and 10/25/2022 8:17:52 AM.
IsRegressionStdDev: Marked as regression because -42.36993528132359 (T) = (0 -53092.1971968693) / Math.Sqrt((458505.5916028295 / (19)) + (349448.86601806263 / (24))) is less than -2.019540970439573 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (19) + (24) - 2, .025) and -0.18620879666505755 = (44757.885244262456 - 53092.1971968693) / 44757.885244262456 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

```#### System.IO.Tests.Perf_File.ReadAllBytes(size: 512)

```log

Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionWindowed: Marked as regression because 27.95751905751906 > 24.168088218545545.
IsChangePoint: Marked as a change because one of 9/7/2022 8:46:47 AM, 9/26/2022 7:45:50 PM, 10/18/2022 9:26:37 AM, 10/25/2022 8:17:52 AM falls between 10/16/2022 1:15:28 PM and 10/25/2022 8:17:52 AM.
IsRegressionStdDev: Marked as regression because -44.0239845653723 (T) = (0 -27802.1076233213) / Math.Sqrt((107259.4613082071 / (20)) + (159117.50881673492 / (22))) is less than -2.0210753903043583 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (20) + (22) - 2, .025) and -0.21612139622006749 = (22861.29304996643 - 27802.1076233213) / 22861.29304996643 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

```#### System.IO.Tests.Perf_File.ReadAllBytes(size: 16384)

```log

Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionWindowed: Marked as regression because 33.2218838764245 > 30.131849436140282.
IsChangePoint: Marked as a change because one of 9/7/2022 8:46:47 AM, 9/26/2022 7:45:50 PM, 10/18/2022 9:26:37 AM, 10/25/2022 8:17:52 AM falls between 10/16/2022 1:15:28 PM and 10/25/2022 8:17:52 AM.
IsRegressionStdDev: Marked as regression because -31.69548067227963 (T) = (0 -33657.392334932156) / Math.Sqrt((207782.11250154 / (19)) + (348730.0804436886 / (23))) is less than -2.0210753903043583 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (19) + (23) - 2, .025) and -0.1794291488550843 = (28537.01925851556 - 33657.392334932156) / 28537.01925851556 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository
@radekdoulik
Copy link
Member

The changes causing this: dotnet/runtime@10fc8ae...fda2fee

One of the few changes is dotnet/runtime#77113. @kotlarmilos is checking the same issue for AOT.

@radekdoulik
Copy link
Member

The related AOT regression #9173

@radekdoulik radekdoulik mentioned this issue Nov 9, 2022
Open
@kotlarmilos
Copy link
Member

Closing this issue as the benchmarks have improved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kotlarmilos kotlarmilos

Labels
arch-wasm arch-x64 branch-refs/heads/main kind-micro os-linux perf-regression
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@radekdoulik @kotlarmilos