-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump BDN to 0.13.1.1728, to pick up fixes for wasm/aot runs #2323
Conversation
I can't access the logs to see if any of the failures are related to this PR. |
Looks like helix is having problems, we will rerun this once it is fixed.
|
This is also going to pick up dotnet/BenchmarkDotNet#1949 which will make life interesting. |
Most failures are of the form (log):
|
And ubuntu 1804 x64 micro Open main:
|
The same errors can be seen in #2320 which doesn't have the bump, so I think all these are unrelated to the PR. |
What needs to happen to unblock this? |
Helix was having problems friday when we were trying to do a check run, but it is back up now. I will go ahead and merge since the tests have run and the failures are either occuring in main or are noisy (micro one), and they have been noted above as occuring otherwise. |
I've merged a fix for that, will send another BDN update later today dotnet/BenchmarkDotNet#1958 |
No description provided.