Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning icon in nuget dependencies tree if TFM shortname is written in different style #2772

Closed
WonyoungChoi opened this issue Aug 30, 2017 · 1 comment
Assignees
Labels
Feature-Dependency-Node "Dependencies" node in Solution Explorer that display project, binary & package references
Milestone

Comments

@WonyoungChoi
Copy link

WonyoungChoi commented Aug 30, 2017

I'm using 15.3.3.

with this csproj,

<Project Sdk="Microsoft.NET.Sdk">
  <PropertyGroup>
    <TargetFramework>netstandard20</TargetFramework>
  </PropertyGroup>
</Project>

the warning icon appears in nuget depedencies tree. but project build succeeds without errors and warnings.

Nuget parses various styles of shortname to produce the same Moniker. ex) netstandard2, netstandard2.0, netstandard20. Therefore it should be resolved successfully in dependencies tree.

I think this is due to the code below. The following code compares the references of two TargetFramework objects, not the Monikers of them.

@davkean davkean added Feature-Dependency-Node "Dependencies" node in Solution Explorer that display project, binary & package references Bug labels Aug 31, 2017
@davkean davkean added this to the 15.6 milestone Aug 31, 2017
@Pilchie
Copy link
Member

Pilchie commented Jan 24, 2018

This is fixed by #3082.

@Pilchie Pilchie closed this as completed Jan 24, 2018
@drewnoakes drewnoakes removed the Bug label Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature-Dependency-Node "Dependencies" node in Solution Explorer that display project, binary & package references
Projects
None yet
Development

No branches or pull requests

5 participants