-
Notifications
You must be signed in to change notification settings - Fork 387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make UpgradeProject work for VB #3141
Comments
We need to confirm with @KathleenDollard, but last I heard this was holding back announcing features released in VB point releases. |
Tagging @KathleenDollard |
@KathleenDollard not sure this is the right place to address this but why doesn't the latest VS version automatically set the compiler version to the latest? VS 2017.7.5 with VB 15.5 set VB compiler version to 15 not 15.5. |
@paul1956 The default project setting (which most people keep, since it's the default) is LangVersion = |
@jcouv I don't see default or latest or anything else a user can set. I know there is "plan" to allow users to set this in the IDE, but can you verify that "default" is actually stored somewhere? Or is the lack of anything stored just giving me "Default" and this unexpected behavior. |
If LangVersion doesn't appear in the project file, you can check its effective value by running msbuild with option '/bl' (which produces a binary/structured log, see "msbuild structured log viewer"). |
This is tracked internally in https://dev.azure.com/devdiv/DevDiv/_workitems/edit/823507 |
Tom's triage notes: I don't think I fully understand what this issue is about. If it is about surfacing a project property than I recommend we fix it for the new project system, but not CSProj. |
Spoke with @jcouv: The essence of this issue is that in C# code dotnet/roslyn can provide a code fix that updates the project file with a newer C# language version. We can't do the same for VB because we don't expose the VB language version property through the project system. I recommend fixing this for CPS, but not the CSProj project system. |
@tmeschter: So the project file supports it and it is used by Visual Studio (I just checked) but we can't get at the value to change it? This is unfortunate. Most VB customers are on .NET Framework and would like to be able to use tuples and several other features. (LangVersion in the project file must be supported to some degree to be used all the places it is.) |
@paul1956 it sounds like you're hitting https://developercommunity.visualstudio.com/content/problem/553000/load-of-property-langversion-failed.html. You can follow that ticket and vote it up to raise its profile. |
The driving scenario is tuple inferred names (#18374) (VB 15.3).
Update: also VB 15.5 features.
ported from dotnet/roslyn#18694
The text was updated successfully, but these errors were encountered: