-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CopyToOutputDirectory Does Not Respect PreserveNewest and TargetPath #7276
Comments
I wonder if CopyToOutputDirectory checks an item's |
This could also be a problem with the project system's fast up-to-date check. Might be interesting to up their verbosity (tools -> options -> Projects and Solutions -> SDK-style Projects -> Up to Date Checks -> Logging Level) and see what they say. |
@benvillalobos, thanks for creating this issue. As a nitpick, the copy paste didn't work correctly. There is some information missing. I avoid that problem by quoting the comment (i.e. click the three dots in the top-right corner and then select "Quote reply"), deleting the initial right angle brackets and spaces, and then copying that text. |
@TysonMN Weird, that seems to be an issue with |
Great suggestion @rainersigwald. Here are the relevant portions of those logs (after optimizing the project structure for smaller logs).
The fast up-to-date check did not take into account the information given in the Specifically, it checked
when it should have checked
|
@TysonMN Aha! Does this also repro on a command line build? |
|
@TysonMN The best way to provide logs for us is with binary logs: aka.ms/msbuild/binlog It'll output a
Verifying it doesn't happen on command line. |
Transferring to project system. We think the fast up to date check has to be updated to account for how MSBuild respects |
Do still want some information from a binlog? I created one, and I see private information in the environment variables, so I don't want share the whole thing. I looked around, but I wasn't able to find anything related to the fast up-to-date check. P.S. |
No thanks @TysonMN; the binlog doesn't contain any information on FUTD and I think we have enough to repro the problem locally. |
Triage notes: I can repro this. We currently plumb through |
Fixed in #7470. |
Hello @benvillalobos. Now that version 16.10 has been released, I am able to test. Unfortunately, I think this change exchanged one problem for another.
I have verified the correctness of the first two lines (i.e. the
Link
andTargetPath
elements). However, the last line with theCopyToOutputDirectory
element is not working. After completing the first build, if I tell Visual Studio to build again, then it builds the project instead of correctly saying that it is update to date.I tested by modifying the MWE I provided in my original VSDC isssue.
Originally posted by @TysonMN in dotnet/msbuild#6237 (comment)
The text was updated successfully, but these errors were encountered: