Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Handle paths with %20 #10957

Open
iyerusad opened this issue Oct 3, 2024 · 0 comments
Open

Bug: Handle paths with %20 #10957

iyerusad opened this issue Oct 3, 2024 · 0 comments
Assignees
Labels
Milestone

Comments

@iyerusad
Copy link

iyerusad commented Oct 3, 2024


name: 🐞 Bug report
about: Create a report to help us improve
title: ''
labels: ''
assignees: ''


Describe the bug:
Razor doesn't appear to handle path with %20 in it e.g. C:\Users\User\Desktop\git\CRM%20Web

Version used:
e.g. VS2022 17.0 Preview 1

To reproduce:
Steps to reproduce the behavior:

  1. Open dotnet project where project folder contains %20
  2. Observe VSCode pop up alert Razor server has crashed.

Expected behavior:
Razor works with folders containing valid filesystem paths.

Actual behavior:
Razor crashes with folders containing valid filesystem paths.

--------------------------------------------------------------------------------
Razor.VSCode version 9.0.0-preview.24418.1
--------------------------------------------------------------------------------
Razor's log level is currently set to 'Debug'
 - To change Razor's log level set 'razor.server.trace' and then restart VSCode.
 - To report issues invoke the 'Report a Razor issue' command via the command palette.
-----------------------------------------------------------------------------------------------------------------------------

Failed to find dotnet info from path, falling back to acquire runtime via ms-dotnettools.vscode-dotnet-runtime
No compatible .NET runtime found. Minimum required version is 8.0.
[Client - 11:18:34 PM] Razor language server path: c:\Users\User\.vscode\extensions\ms-dotnettools.csharp-2.45.25-win32-x64\.razor\rzls.exe
[Client - 11:18:34 PM] Server arguments --logLevel 1 --DelegateToCSharpOnDiagnosticPublish true --UpdateBuffersForClosedDocuments true --SingleServerCompletionSupport true
[Client - 11:18:34 PM] Starting Razor Language Server...
[Client - 11:18:35 PM] Server started, waiting for client to be ready...
[Client - 11:18:35 PM] Server ready!
[Info  - 11:18:35 PM] [CLaSP] [StartContext] initialize
[Info  - 11:18:35 PM] [RZLS] Razor Language Server started successfully.
[Info  - 11:18:35 PM] [CLaSP] [StartContext] initialized
[Info  - 11:18:35 PM] [CLaSP] Using default language handler for initialize: 
[Info  - 11:18:35 PM] [CLaSP] [EndContext] initialize
[Info  - 11:18:35 PM] [CLaSP] Using default language handler for initialized: 
[Error - 11:18:35 PM] [CLaSP] [null]: System.ArgumentException: The directory name 'c:/Users/User/Desktop/git/CRM Web' does not exist. (Parameter 'path')   at System.IO.FileSystemWatcher.CheckPathValidity(String path)   at System.IO.FileSystemWatcher..ctor(String path, String filter)   at Microsoft.AspNetCore.Razor.LanguageServer.RazorFileChangeDetector.StartAsync(String workspaceDirectory, CancellationToken cancellationToken) in /_/src/Razor/src/Microsoft.AspNetCore.Razor.LanguageServer/RazorFileChangeDetector.cs:line 168   at Microsoft.AspNetCore.Razor.LanguageServer.RazorFileChangeDetectorManager.OnInitializedAsync(ILspServices services, CancellationToken cancellationToken) in /_/src/Razor/src/Microsoft.AspNetCore.Razor.LanguageServer/RazorFileChangeDetectorManager.cs:line 31   at Microsoft.AspNetCore.Razor.LanguageServer.RazorInitializedEndpoint.HandleNotificationAsync(InitializedParams request, RazorRequestContext requestContext, CancellationToken cancellationToken) in /_/src/Razor/src/Microsoft.AspNetCore.Razor.LanguageServer/RazorInitializedEndpoint.cs:line 25   at Microsoft.CommonLanguageServerProtocol.Framework.QueueItem`1.StartRequestAsync[TRequest,TResponse](TRequest request, TRequestContext context, IMethodHandler handler, String language, CancellationToken cancellationToken) in /_3/QueueItem.cs:line 199
[Info  - 11:18:35 PM] [CLaSP] [EndContext] initialized
PS C:\Users\User> ls c:/Users/User/Desktop/git/


    Directory: C:\Users\User\Desktop\git


Mode                 LastWriteTime         Length Name
----                 -------------         ------ ----
d-----          8/2/2023   5:51 PM                CRM%20API
d-----         10/2/2024   9:46 PM                CRM%20Web
d-----          8/2/2022   5:51 AM                test

Additional context:
These are clones of git repos named/created during VSTS days. Not sure if newer Azure DevOps based repos behave differently with spaces.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants