[release/dev17.8] Update dependencies from dotnet/arcade #10783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dotnet-maestro[bot]](https://avatars.githubusercontent.com/in/16706?s=60&v=4){kind=small}
…821.4 Microsoft.DotNet.Arcade.Sdk From Version 8.0.0-beta.23463.1 -> To Version 8.0.0-beta.24421.4 Dependency coherency updates Microsoft.DotNet.XliffTasks From Version 1.0.0-beta.23426.1 -> To Version 1.0.0-beta.23475.1 (parent: Microsoft.DotNet.Arcade.Sdk
![dotnet-policy-service[bot]](https://avatars.githubusercontent.com/in/285228?s=60&v=4){kind=small}
…826.2 Microsoft.DotNet.Arcade.Sdk From Version 8.0.0-beta.24421.4 -> To Version 8.0.0-beta.24426.2
…909.4 Microsoft.DotNet.Arcade.Sdk From Version 8.0.0-beta.24426.2 -> To Version 8.0.0-beta.24459.4
…910.4 Microsoft.DotNet.Arcade.Sdk From Version 8.0.0-beta.24459.4 -> To Version 8.0.0-beta.24460.4
…911.1 Microsoft.DotNet.Arcade.Sdk From Version 8.0.0-beta.24460.4 -> To Version 8.0.0-beta.24461.1
…911.2 Microsoft.DotNet.Arcade.Sdk From Version 8.0.0-beta.24461.1 -> To Version 8.0.0-beta.24461.2
…913.3 Microsoft.DotNet.Arcade.Sdk From Version 8.0.0-beta.24461.2 -> To Version 8.0.0-beta.24463.3
|
I follow the same pattern in dotnet/roslyn#70248 to disable the warnings |
jaredpar
reviewed
Sep 23, 2024
| @@ -44,7 +44,9 @@ public string ToBase64String() | |||
| { | |||
| #if NETCOREAPP | |||
| Span<byte> bytes = stackalloc byte[HashSize]; | |||
| #pragma warning disable CS9191 // The 'ref' modifier for an argument corresponding to 'in' parameter is equivalent to 'in'. Consider using 'in' instead. | |||
There was a problem hiding this comment.
Another way might be to separate the impl into
if NET8_0_OR_GREATER
MemoryMarshal.TryWrite(bytes, in Unsafe.AsRef(in Data));
else
MemoryMarshal.TryWrite(bytes, ref Unsafe.AsRef(in Data));
There was a problem hiding this comment.
Blarg. Worried that might be it. Okay let's merge it like this for now.
jaredpar
approved these changes
Sep 23, 2024
Cosifne
deleted the
darc-release/dev17.8-c9f60317-3831-436b-bad6-24a4d274049d
branch
This was referenced Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the following dependencies
Coherency Updates
The following updates ensure that dependencies with a CoherentParentDependency
attribute were produced in a build used as input to the parent dependency's build.
See Dependency Description Format
From https://github.com/dotnet/arcade