-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fuse fix usings #10925
Fuse fix usings #10925
Conversation
@dotnet/roslyn-compiler for review please :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM from tooling side. Just to verify did you check folding ranges with multiple usings?
src/Shared/Microsoft.AspNetCore.Razor.Test.Common/GenerateBaselines.cs
Outdated
Show resolved
Hide resolved
Yeah, I loaded it up into the experimental hive and confirmed it did what was expected (and went back to the buggy behavior if I reverted) |
Applies the same approach we took in 408765e to
@using
directives.We need to specifically do this because today
@using
is handled specially in the parser rather than being a regular directive that would have benefitted from the previous change.Fixes: #10859