Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fuse fix usings #10925

Merged
merged 9 commits into from
Sep 27, 2024
Merged

Fuse fix usings #10925

merged 9 commits into from
Sep 27, 2024

Conversation

chsienki
Copy link
Contributor

@chsienki chsienki commented Sep 25, 2024

Applies the same approach we took in 408765e to @using directives.

We need to specifically do this because today @using is handled specially in the parser rather than being a regular directive that would have benefitted from the previous change.

Fixes: #10859

@chsienki chsienki added area-compiler Umbrella for all compiler issues New Feature: Fuse labels Sep 25, 2024
@chsienki chsienki requested review from a team as code owners September 25, 2024 23:23
@chsienki
Copy link
Contributor Author

@dotnet/roslyn-compiler for review please :)

@chsienki chsienki changed the base branch from main to release/dev17.12 September 25, 2024 23:24
@chsienki chsienki changed the base branch from release/dev17.12 to main September 25, 2024 23:25
Copy link
Contributor

@ryzngard ryzngard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from tooling side. Just to verify did you check folding ranges with multiple usings?

@chsienki
Copy link
Contributor Author

chsienki commented Sep 25, 2024

LGTM from tooling side. Just to verify did you check folding ranges with multiple usings?

Yeah, I loaded it up into the experimental hive and confirmed it did what was expected (and went back to the buggy behavior if I reverted)

@chsienki chsienki changed the title Fuse fix includes Fuse fix usings Sep 27, 2024
@chsienki chsienki enabled auto-merge (squash) September 27, 2024 00:09
@chsienki chsienki merged commit 4b1b541 into dotnet:main Sep 27, 2024
12 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Sep 27, 2024
@phil-allen-msft phil-allen-msft removed this from the Next milestone Oct 31, 2024
@phil-allen-msft phil-allen-msft added this to the 17.12 P3 milestone Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-compiler Umbrella for all compiler issues New Feature: Fuse
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FUSE] Each @using directive gets its own folding range, unnecessarily
5 participants