Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpin Roslyn Versions #10994

Merged
merged 2 commits into from
Oct 10, 2024
Merged

Unpin Roslyn Versions #10994

merged 2 commits into from
Oct 10, 2024

Conversation

333fred
Copy link
Member

@333fred 333fred commented Oct 9, 2024

Now that we have the analyzer work done in VS, we should be able to unpin the versions of the roslyn compiler that we depend on in razor.

Now that we have the analyzer work done in VS, we should be able to unpin the versions of the roslyn compiler that we depend on in razor.
@333fred 333fred requested a review from a team as a code owner October 9, 2024 22:45
@333fred
Copy link
Member Author

333fred commented Oct 9, 2024

@dotnet/razor-compiler for reviews. If anyone has suggestions for what they'd like to see for validation, please chime in.

Copy link
Member

@jaredpar jaredpar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think we can remove a lot of the VersionOverride now.

@333fred 333fred requested a review from jaredpar October 10, 2024 17:20
@333fred 333fred merged commit 4c78255 into dotnet:main Oct 10, 2024
12 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Oct 10, 2024
@333fred 333fred deleted the remove-pinning branch October 10, 2024 21:45
@phil-allen-msft phil-allen-msft modified the milestones: Next, 17.13 P1 Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants