From 486953462173a0fdc135554e342a63f8d1b9338e Mon Sep 17 00:00:00 2001 From: AbhineshJha Date: Wed, 1 Nov 2023 02:08:32 +0530 Subject: [PATCH] docs(grammatical): correct typos --- docs/NetCore_GettingStarted.md | 2 +- docs/Performance.md | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/NetCore_GettingStarted.md b/docs/NetCore_GettingStarted.md index 7d9a02b3c0..56cc136f65 100644 --- a/docs/NetCore_GettingStarted.md +++ b/docs/NetCore_GettingStarted.md @@ -38,7 +38,7 @@ - Run the analyzer locally against `dotnet/runtime` and `dotnet/roslyn-analyzers` [(instructions)](#testing-against-the-runtime-and-roslyn-analyzers-repo). - Review each of the failures in those repositories and determine the course of action for each. - Use the failures to discover nuance and guide the implementation details. - - Run the analyzer against `dotnet/roslyn` [(instructions)](#testing-against-the-roslyn-repo), and if feasable with `dotnet/aspnetcore` repos. + - Run the analyzer against `dotnet/roslyn` [(instructions)](#testing-against-the-roslyn-repo), and if feasible with `dotnet/aspnetcore` repos. - Document for review: matching and non-matching scenarios, including any discovered nuance. - All warnings and errors in these repos are addressed (to prevent build failures) - `Info` level diagnostics do not need to be fully resolved or suppressed as they do not cause build failures diff --git a/docs/Performance.md b/docs/Performance.md index 52f1ba84ed..86fee2370b 100644 --- a/docs/Performance.md +++ b/docs/Performance.md @@ -47,7 +47,7 @@ These tests are expected to live in the dotnet/roslyn-analyzers repo to make loc #### End-to-End Tests -An end-to-end compilation test that measures how long the build takes on a large real-world project (based off existing scenarios [here](https://github.com/dotnet/performance/blob/main/docs/sdk-scenarios.md#sdk-build-throughput-scenario)). This test will be run twice, once with all muti-core build features disabled (no `/m` is passed to msbuild, and `/parallel-` is passed to the compiler) and once with the SDK defaults enabled. The reason we will want a test with no parallelism is to make it easier to see the source of regressions. These test will not just measure how long it takes analyzers to execute but the entire SDK-based build process. It will need to collect an ETL file for investigation as well as the following metrics in a binlog file +An end-to-end compilation test that measures how long the build takes on a large real-world project (based off existing scenarios [here](https://github.com/dotnet/performance/blob/main/docs/sdk-scenarios.md#sdk-build-throughput-scenario)). This test will be run twice, once with all mutli-core build features disabled (no `/m` is passed to msbuild, and `/parallel-` is passed to the compiler) and once with the SDK defaults enabled. The reason we will want a test with no parallelism is to make it easier to see the source of regressions. These test will not just measure how long it takes analyzers to execute but the entire SDK-based build process. It will need to collect an ETL file for investigation as well as the following metrics in a binlog file - How much time was spend in analysis (`/p:reportanalyzer=true`) - How long each build task took (recorded by default in the binlog file)