Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New analyzer: Do not call BeginInvoke on a delegate for .NET Core #2807

Open
sharwell opened this issue Sep 3, 2019 · 3 comments
Open

New analyzer: Do not call BeginInvoke on a delegate for .NET Core #2807

sharwell opened this issue Sep 3, 2019 · 3 comments
Labels
Approved-Rule Indicates if the new proposed rule has been approved to move to implementation phase Feature Request help wanted The issue is up-for-grabs, and can be claimed by commenting
Milestone
Unknown

Comments

@sharwell
Copy link
Member

sharwell commented Sep 3, 2019 •
edited
Loading

This would apply to projects targeting .NET Standard or .NET Core.

https://github.com/dotnet/corefx/issues/5940 dotnet/runtime#16312
dotnet/winforms#1548
@mavasani mavasani added Feature Request Needs-Review Approved-Rule Indicates if the new proposed rule has been approved to move to implementation phase help wanted The issue is up-for-grabs, and can be claimed by commenting and removed Needs-Review labels Sep 9, 2019
@mavasani mavasani added this to the Unknown milestone Sep 9, 2019
@duracellko duracellko mentioned this issue Oct 24, 2019
Closed
@jkotas jkotas mentioned this issue Apr 11, 2023
Closed
@danmoseley
Copy link
Member

Or EndInvoke, right?

@sharwell
Copy link
Member Author

@danmoseley I wouldn't expect users to continue calling EndInvoke after the calls to BeginInvoke were removed. Isn't the return value from BeginInvoke one of the arguments to EndInvoke?

@LunarWhisper
Copy link

@danmoseley I wouldn't expect users to continue calling EndInvoke after the calls to BeginInvoke were removed. Isn't the return value from BeginInvoke one of the arguments to EndInvoke?

Task implements IAsyncResult so we need to check EndInvoke too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Approved-Rule Indicates if the new proposed rule has been approved to move to implementation phase Feature Request help wanted The issue is up-for-grabs, and can be claimed by commenting
Projects
None yet
Milestone
Unknown
Development

No branches or pull requests
4 participants
@sharwell @danmoseley @mavasani @LunarWhisper