GetOrCreateTypeByMetadataName is called on every attribute syntax callback

[Youssef1313]

roslyn-analyzers/src/NetAnalyzers/CSharp/Microsoft.NetCore.Analyzers/Resources/CSharpMarkAssembliesWithNeutralResourcesLanguage.cs

Lines 20 to 34 in 5968bec

	context.RegisterSyntaxNodeAction(nc =>
	{
	if (!CheckAttribute(nc.Node))
	{
	return;
	}
	if (!CheckResxGeneratedFile(nc.SemanticModel, nc.Node, ((AttributeSyntax)nc.Node).ArgumentList.Arguments[0].Expression, nc.CancellationToken))
	{
	return;
	}
	onResourceFound();
	}, SyntaxKind.Attribute);
	}

roslyn-analyzers/src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/Resources/MarkAssembliesWithNeutralResourcesLanguage.cs

Lines 92 to 99 in 5968bec

	protected static bool CheckResxGeneratedFile(SemanticModel model, SyntaxNode attribute, SyntaxNode argument, CancellationToken cancellationToken)
	{
	if (!CheckDesignerFile(model.SyntaxTree))
	{
	return false;
	}
	INamedTypeSymbol? generatedCode = model.Compilation.GetOrCreateTypeByMetadataName(WellKnownTypeNames.SystemCodeDomCompilerGeneratedCodeAttribute);

Should see if this impacts performance and move the call to GetOrCreateTypeByMetadataName(WellKnownTypeNames.SystemCodeDomCompilerGeneratedCodeAttribute); to the compilation start action

[Evangelink]

Impact should be relatively moderated (method call + dict lookup) but the PR is still totally worth it.