Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CA1839: Avoid const arrays [NO MERGE] #5379

Closed
wants to merge 368 commits into from
Closed

CA1839: Avoid const arrays [NO MERGE] #5379

wants to merge 368 commits into from
This pull request is big! We’re only showing the most recent 250 commits.

Commits on Feb 27, 2021

  1. Merge branch 'release/6.0.1xx-preview2' into use-CancellationToken-Th… 

    …rowIfCancellationRequested
    @NewellClark
    NewellClark authored Feb 27, 2021
    Configuration menu
    Copy the full SHA
    d16627f View commit details
    Browse the repository at this point in the history

Commits on Mar 3, 2021

  1. Merge pull request #4887 from dotnet/merges/master-to-release/6.0.1xx… 

    …-preview3

Merge master to release/6.0.1xx-preview3
    @mavasani
    mavasani authored Mar 3, 2021
    Configuration menu
    Copy the full SHA
    dea6979 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'release/6.0.1xx-preview2' into merges/release/6.0.1xx-p… 

    …review1-to-release/6.0.1xx-preview2
    @jmarolf
    jmarolf authored Mar 3, 2021
    Configuration menu
    Copy the full SHA
    e6a7324 View commit details
    Browse the repository at this point in the history

  3. Merge pull request #4924 from dotnet/merges/master-to-release/6.0.1xx… 

    …-preview3
    @jmarolf
    jmarolf authored Mar 3, 2021
    Configuration menu
    Copy the full SHA
    c054652 View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2021

  1. Add analyzers/fixers for Environment.ProcessPath and CurrentManagedTh… 

    …readId (#4909)

* Add analyzers/fixers for Environment.ProcessPath and CurrentManagedThreadId

* Address PR feedback
    @stephentoub
    stephentoub authored Mar 8, 2021
    Configuration menu
    Copy the full SHA
    940c426 View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2021

  1. Merge pull request #4867 from dotnet/merges/release/6.0.1xx-preview1-… 

    …to-release/6.0.1xx-preview2
    @jmarolf
    jmarolf authored Mar 15, 2021
    Configuration menu
    Copy the full SHA
    eefe897 View commit details
    Browse the repository at this point in the history

  2. Merge release/6.0.1xx-preview2 to release/6.0.1xx-preview3 (#4902) 

    * CA-1418 Validate platform string (#4838)
    @dotnet-bot
    dotnet-bot authored Mar 15, 2021
    Configuration menu
    Copy the full SHA
    8eb850e View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2021

  1. Merge remote-tracking branch 'dotnet/release/6.0.1xx-preview2' into m… 

    …erges/release/6.0.1xx-preview2-to-release/6.0.1xx-preview3
    @buyaa-n
    buyaa-n committed Mar 18, 2021
    Configuration menu
    Copy the full SHA
    df5ddc4 View commit details
    Browse the repository at this point in the history

  2. OSX is alias for MacOS (#4952) 

    * OSX is alias for MacOS
    @buyaa-n
    buyaa-n authored Mar 18, 2021
    Configuration menu
    Copy the full SHA
    988eaf5 View commit details
    Browse the repository at this point in the history

Commits on Mar 23, 2021

  1. Update Versions.props

    @jmarolf
    jmarolf authored Mar 23, 2021
    Configuration menu
    Copy the full SHA
    5abaa41 View commit details
    Browse the repository at this point in the history

Commits on Mar 30, 2021

  1. Merge pull request #4951 from dotnet/merges/release/6.0.1xx-preview2-… 

    …to-release/6.0.1xx-preview3

Merge release/6.0.1xx-preview2 to release/6.0.1xx-preview3
    @mmitche
    mmitche authored Mar 30, 2021
    Configuration menu
    Copy the full SHA
    262ddfd View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2021

  1. Merge pull request #4987 from dotnet/merges/release/6.0.1xx-preview3-… 

    …to-release/6.0.1xx-preview4

Merge release/6.0.1xx-preview3 to release/6.0.1xx-preview4
    @mavasani
    mavasani authored Apr 8, 2021
    Configuration menu
    Copy the full SHA
    2dda3d3 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #4949 from dotnet/merges/release/6.0.1xx-preview1-… 

    …to-release/6.0.1xx-preview2

Merge release/6.0.1xx-preview1 to release/6.0.1xx-preview2
    @mavasani
    mavasani authored Apr 8, 2021
    Configuration menu
    Copy the full SHA
    e46220a View commit details
    Browse the repository at this point in the history

  3. Remove unsupported attribute when allow deny list mixed (#5000)

    @buyaa-n
    buyaa-n authored Apr 8, 2021
    Configuration menu
    Copy the full SHA
    1dcfb32 View commit details
    Browse the repository at this point in the history

Commits on Apr 9, 2021

  1. Merge pull request #5004 from dotnet/merges/release/6.0.1xx-preview2-… 

    …to-release/6.0.1xx-preview3

Merge release/6.0.1xx-preview2 to release/6.0.1xx-preview3
    @jmarolf
    jmarolf authored Apr 9, 2021
    Configuration menu
    Copy the full SHA
    43dfa18 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/main' into merges/main-to-rele… 

    …ase/6.0.1xx-preview4
    @jmarolf
    jmarolf committed Apr 9, 2021
    Configuration menu
    Copy the full SHA
    04c867f View commit details
    Browse the repository at this point in the history

  3. Merge pull request #4976 from dotnet/merges/main-to-release/6.0.1xx-p… 

    …review4

Merge main to release/6.0.1xx-preview4
    @jmarolf
    jmarolf authored Apr 9, 2021
    Configuration menu
    Copy the full SHA
    e112315 View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2021

  1. Merge pull request #5010 from dotnet/merges/release/6.0.1xx-preview3-… 

    …to-release/6.0.1xx-preview4

Merge release/6.0.1xx-preview3 to release/6.0.1xx-preview4
    @jmarolf
    jmarolf authored Apr 12, 2021
    Configuration menu
    Copy the full SHA
    6c23dc8 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #5015 from dotnet/merges/main-to-release/6.0.1xx-p… 

    …review4

Merge main to release/6.0.1xx-preview4
    @jmarolf
    jmarolf authored Apr 12, 2021
    Configuration menu
    Copy the full SHA
    86b88db View commit details
    Browse the repository at this point in the history

Commits on Apr 13, 2021

  1. OSX needs to treated as the same platform as MacOS, everywhere (#5012) 

    * OSX same as MacOS, need to treated as same everywhere
    @buyaa-n
    buyaa-n authored Apr 13, 2021
    Configuration menu
    Copy the full SHA
    135e126 View commit details
    Browse the repository at this point in the history

Commits on Apr 14, 2021

  1. Merge pull request #5017 from dotnet/merges/main-to-release/6.0.1xx-p… 

    …review4

Merge main to release/6.0.1xx-preview4
    @mavasani
    mavasani authored Apr 14, 2021
    Configuration menu
    Copy the full SHA
    be17383 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'release/6.0.1xx-preview4' into merges/main-to-release/6… 

    ….0.1xx-preview4
    @mavasani
    mavasani authored Apr 14, 2021
    Configuration menu
    Copy the full SHA
    acf8240 View commit details
    Browse the repository at this point in the history

  3. Merge pull request #5018 from dotnet/merges/main-to-release/6.0.1xx-p… 

    …review4

Merge main to release/6.0.1xx-preview4
    @mavasani
    mavasani authored Apr 14, 2021
    Configuration menu
    Copy the full SHA
    e30830b View commit details
    Browse the repository at this point in the history

  4. Merge pull request #5019 from dotnet/merges/main-to-release/6.0.1xx-p… 

    …review4

Merge main to release/6.0.1xx-preview4
    @jmarolf
    jmarolf authored Apr 14, 2021
    Configuration menu
    Copy the full SHA
    a513416 View commit details
    Browse the repository at this point in the history

Commits on Apr 15, 2021

  1. Merge pull request #5020 from dotnet/merges/main-to-release/6.0.1xx-p… 

    …review4

Merge main to release/6.0.1xx-preview4
    @mavasani
    mavasani authored Apr 15, 2021
    Configuration menu
    Copy the full SHA
    d993fd4 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'release/6.0.1xx-preview4' into merges/main-to-release/6… 

    ….0.1xx-preview4
    @mavasani
    mavasani authored Apr 15, 2021
    Configuration menu
    Copy the full SHA
    ee92c7f View commit details
    Browse the repository at this point in the history

  3. Merge pull request #5022 from dotnet/merges/main-to-release/6.0.1xx-p… 

    …review4

Merge main to release/6.0.1xx-preview4
    @jmarolf
    jmarolf authored Apr 15, 2021
    Configuration menu
    Copy the full SHA
    157932f View commit details
    Browse the repository at this point in the history

  4. Update Versions.props

    @jmarolf
    jmarolf authored Apr 15, 2021
    Configuration menu
    Copy the full SHA
    1b1660d View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2021

  1. Add CSharp analyzer and tests

    @ryzngard
    ryzngard committed Apr 16, 2021
    Configuration menu
    Copy the full SHA
    d8512c8 View commit details
    Browse the repository at this point in the history

  2. Add VB analyzer and tests

    @ryzngard
    ryzngard committed Apr 16, 2021
    Configuration menu
    Copy the full SHA
    accfc0e View commit details
    Browse the repository at this point in the history

  3. Fix WaitAll message and title

    @ryzngard
    ryzngard committed Apr 16, 2021
    Configuration menu
    Copy the full SHA
    19c9121 View commit details
    Browse the repository at this point in the history

  4. Add code fix and tests

    @ryzngard
    ryzngard committed Apr 16, 2021
    Configuration menu
    Copy the full SHA
    a99dc38 View commit details
    Browse the repository at this point in the history

  5. Add unfixed cases to tests

    @ryzngard
    ryzngard committed Apr 16, 2021
    Configuration menu
    Copy the full SHA
    c37cfa4 View commit details
    Browse the repository at this point in the history

  6. Run msbuild /t:pack /v:m

    @ryzngard
    ryzngard committed Apr 16, 2021
    Configuration menu
    Copy the full SHA
    92a6d9f View commit details
    Browse the repository at this point in the history

  7. Format

    @ryzngard
    ryzngard committed Apr 16, 2021
    Configuration menu
    Copy the full SHA
    29858e3 View commit details
    Browse the repository at this point in the history

  8. Add assert

    @ryzngard
    ryzngard committed Apr 16, 2021
    Configuration menu
    Copy the full SHA
    79b0c78 View commit details
    Browse the repository at this point in the history

  9. Apply suggestions from code review 

    Co-authored-by: Youssef Victor <31348972+Youssef1313@users.noreply.github.com>
    @ryzngard @Youssef1313
    ryzngard and Youssef1313 committed Apr 16, 2021
    Configuration menu
    Copy the full SHA
    50da58c View commit details
    Browse the repository at this point in the history

  10. Update xlf files

    @ryzngard
    ryzngard committed Apr 16, 2021
    Configuration menu
    Copy the full SHA
    5f0762b View commit details
    Browse the repository at this point in the history

  11. Remove need for language specific syntax in analyzer

    @ryzngard
    ryzngard committed Apr 16, 2021
    Configuration menu
    Copy the full SHA
    6e63890 View commit details
    Browse the repository at this point in the history

  12. Move to performance instead of usage

    @ryzngard
    ryzngard committed Apr 16, 2021
    Configuration menu
    Copy the full SHA
    59e68f9 View commit details
    Browse the repository at this point in the history

  13. Change to CA1839 and CA1840

    @ryzngard
    ryzngard committed Apr 16, 2021
    Configuration menu
    Copy the full SHA
    ba0c6ce View commit details
    Browse the repository at this point in the history

  14. Fix IsSingleTaskArgument

    @ryzngard
    ryzngard committed Apr 16, 2021
    Configuration menu
    Copy the full SHA
    c9a5de5 View commit details
    Browse the repository at this point in the history

  15. Merge pull request #5029 from dotnet/merges/main-to-release/6.0.1xx 

    Merge main to release/6.0.1xx
    @jmarolf
    jmarolf authored Apr 16, 2021
    Configuration menu
    Copy the full SHA
    8d70630 View commit details
    Browse the repository at this point in the history

  16. Change diagnostic id after rebase

    @ryzngard
    ryzngard committed Apr 16, 2021
    Configuration menu
    Copy the full SHA
    11ddf1c View commit details
    Browse the repository at this point in the history

  17. PR feedback

    @ryzngard
    ryzngard committed Apr 16, 2021
    Configuration menu
    Copy the full SHA
    604a1f0 View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2021

  1. - Apply requested changes 

    - Rename CSharpDictionaryContainsMethodsFixer.cs and BasicDictionaryContainsMethodsFixer.vb to be more consistent with other fixer file names
    @NewellClark
    NewellClark committed Apr 18, 2021
    Configuration menu
    Copy the full SHA
    6c41960 View commit details
    Browse the repository at this point in the history

  2. Run msbuild

    @NewellClark
    NewellClark committed Apr 18, 2021
    Configuration menu
    Copy the full SHA
    da54da0 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'release/6.0.1xx-preview4' into issue-35343

    @NewellClark
    NewellClark authored Apr 18, 2021
    Configuration menu
    Copy the full SHA
    fa6aa18 View commit details
    Browse the repository at this point in the history

  4. Fix resx tag garbled in merge.

    @NewellClark
    NewellClark committed Apr 18, 2021
    Configuration menu
    Copy the full SHA
    a4fc8ad View commit details
    Browse the repository at this point in the history

Commits on Apr 20, 2021

  1. Update dependencies from https://github.com/dotnet/arcade build 20210… 

    …419.2 (#5039)

[release/6.0.1xx-preview4] Update dependencies from dotnet/arcade
    @dotnet-maestro
    dotnet-maestro[bot] authored Apr 20, 2021
    Configuration menu
    Copy the full SHA
    4cc3687 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'release/6.0.1xx' into merges/main-to-release/6.0.1xx

    @jmarolf
    jmarolf authored Apr 20, 2021
    Configuration menu
    Copy the full SHA
    88f3e55 View commit details
    Browse the repository at this point in the history

  3. Merge pull request #5031 from dotnet/merges/main-to-release/6.0.1xx 

    Merge main to release/6.0.1xx
    @jmarolf
    jmarolf authored Apr 20, 2021
    Configuration menu
    Copy the full SHA
    653d04d View commit details
    Browse the repository at this point in the history

  4. Update src/NetAnalyzers/Core/AnalyzerReleases.Unshipped.md 

    Co-authored-by: Manish Vasani <mavasani@microsoft.com>
    @NewellClark @mavasani
    NewellClark and mavasani authored Apr 20, 2021
    Configuration menu
    Copy the full SHA
    cdac0be View commit details
    Browse the repository at this point in the history

  5. Change doc link to ca1841

    @NewellClark
    NewellClark authored Apr 20, 2021
    Configuration menu
    Copy the full SHA
    2b25aa9 View commit details
    Browse the repository at this point in the history

  6. Apply requested changes 

    - Change ID to CA1842
    @NewellClark
    NewellClark committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    3925794 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'release/6.0.1xx-preview4' into issue-33789

    @NewellClark
    NewellClark authored Apr 20, 2021
    Configuration menu
    Copy the full SHA
    761578e View commit details
    Browse the repository at this point in the history

  8. Add newline to end of resx file

    @NewellClark
    NewellClark authored Apr 20, 2021
    Configuration menu
    Copy the full SHA
    a4e6374 View commit details
    Browse the repository at this point in the history

  9. Add newline character

    @NewellClark
    NewellClark authored Apr 20, 2021
    Configuration menu
    Copy the full SHA
    f481548 View commit details
    Browse the repository at this point in the history

  10. CA1416 fix ambiguity in Version comparison (#4943)

    @buyaa-n
    buyaa-n authored Apr 20, 2021
    Configuration menu
    Copy the full SHA
    c46ba49 View commit details
    Browse the repository at this point in the history

  11. Merge branch 'release/6.0.1xx' into merges/release/6.0.1xx-preview4-t… 

    …o-release/6.0.1xx
    @jmarolf
    jmarolf authored Apr 20, 2021
    Configuration menu
    Copy the full SHA
    b8df54b View commit details
    Browse the repository at this point in the history

  12. Merge pull request #5042 from dotnet/merges/release/6.0.1xx-preview4-… 

    …to-release/6.0.1xx

Merge release/6.0.1xx-preview4 to release/6.0.1xx
    @jmarolf
    jmarolf authored Apr 20, 2021
    Configuration menu
    Copy the full SHA
    1c73932 View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2021

  1. Merge branch 'release/6.0.1xx-preview4' into issue-35343

    @mavasani
    mavasani authored Apr 21, 2021
    Configuration menu
    Copy the full SHA
    1135ad2 View commit details
    Browse the repository at this point in the history

  2. Fix garbled unshipped.md markup

    @NewellClark
    NewellClark authored Apr 21, 2021
    Configuration menu
    Copy the full SHA
    b2dc2cc View commit details
    Browse the repository at this point in the history

  3. Merge pull request #4687 from NewellClark/issue-35343 

    (1/4) Issue 35343 - Replace Dictionary<,>.Keys.Contains with Dictionary<,>.ContainsKey
    @mavasani
    mavasani authored Apr 21, 2021
    Configuration menu
    Copy the full SHA
    138ab76 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'release/6.0.1xx-preview4' into issue-33789

    @NewellClark
    NewellClark authored Apr 21, 2021
    Configuration menu
    Copy the full SHA
    516e775 View commit details
    Browse the repository at this point in the history

  5. Merge remote-tracking branch 'upstream/release/6.0.1xx-preview4' into… 

    … feature/task_when_wait_all_analyzer
    @ryzngard
    ryzngard committed Apr 21, 2021
    Configuration menu
    Copy the full SHA
    719e4c5 View commit details
    Browse the repository at this point in the history

  6. Add rules back to AnalyzerReleases.Unshipped

    @ryzngard
    ryzngard committed Apr 21, 2021
    Configuration menu
    Copy the full SHA
    7285360 View commit details
    Browse the repository at this point in the history

  7. Fix spacing in test

    @ryzngard
    ryzngard committed Apr 21, 2021
    Configuration menu
    Copy the full SHA
    0ae0ff3 View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2021

  1. Merge pull request #5052 from dotnet/merges/main-to-release/6.0.1xx 

    Merge main to release/6.0.1xx
    @mavasani
    mavasani authored Apr 22, 2021
    Configuration menu
    Copy the full SHA
    1b019d6 View commit details
    Browse the repository at this point in the history

  2. Update src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/Tasks/DoNotU… 

    …seWhenAllOrWaitAllWithSingleArgument.cs

Co-authored-by: Manish Vasani <mavasani@microsoft.com>
    @ryzngard @mavasani
    ryzngard and mavasani authored Apr 22, 2021
    Configuration menu
    Copy the full SHA
    81ceec1 View commit details
    Browse the repository at this point in the history

  3. Update description wording

    @ryzngard
    ryzngard committed Apr 22, 2021
    Configuration menu
    Copy the full SHA
    02947da View commit details
    Browse the repository at this point in the history

  4. Updated documentation based on description

    @ryzngard
    ryzngard committed Apr 22, 2021
    Configuration menu
    Copy the full SHA
    dd00427 View commit details
    Browse the repository at this point in the history

  5. Merge pull request #4841 from ryzngard/feature/task_when_wait_all_ana… 

    …lyzer

Add WhenAll and WaitAll analyzer for single task argument
    @ryzngard
    ryzngard authored Apr 22, 2021
    Configuration menu
    Copy the full SHA
    535cbe7 View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2021

  1. Cleanup DoNotUseWhenAllOrWaitAllWithSingleArgument

    @Youssef1313
    Youssef1313 committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    e8712e8 View commit details
    Browse the repository at this point in the history

  2. Another approach

    @Youssef1313
    Youssef1313 committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    0b5e5c1 View commit details
    Browse the repository at this point in the history

  3. Merge pull request #5060 from Youssef1313/cleanup 

    Cleanup DoNotUseWhenAllOrWaitAllWithSingleArgument
    @ryzngard
    ryzngard authored Apr 23, 2021
    Configuration menu
    Copy the full SHA
    d515202 View commit details
    Browse the repository at this point in the history

  4. Change ID to CA1844

    @NewellClark
    NewellClark committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    31b78e9 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'release/6.0.1xx-preview4' into issue-33789

    @NewellClark
    NewellClark authored Apr 23, 2021
    Configuration menu
    Copy the full SHA
    a320e17 View commit details
    Browse the repository at this point in the history

  6. Fix failing CA

    @NewellClark
    NewellClark committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    81eda27 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'release/6.0.1xx' into merges/main-to-release/6.0.1xx

    @jmarolf
    jmarolf authored Apr 23, 2021
    Configuration menu
    Copy the full SHA
    e33c584 View commit details
    Browse the repository at this point in the history

  8. Merge remote-tracking branch 'upstream/release/6.0.1xx-preview4' into… 

    … merges/release/6.0.1xx-preview4-to-release/6.0.1xx
    @jmarolf
    jmarolf committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    5e2cb00 View commit details
    Browse the repository at this point in the history

  9. fixup bad merge

    @jmarolf
    jmarolf committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    274ad2a View commit details
    Browse the repository at this point in the history

  10. Apply formatting changes 

    Co-authored-by: Manish Vasani <mavasani@microsoft.com>
    @NewellClark @mavasani
    NewellClark and mavasani authored Apr 23, 2021
    Configuration menu
    Copy the full SHA
    822659c View commit details
    Browse the repository at this point in the history

  11. Merge pull request #5056 from dotnet/merges/main-to-release/6.0.1xx 

    Merge main to release/6.0.1xx
    @jmarolf
    jmarolf authored Apr 23, 2021
    Configuration menu
    Copy the full SHA
    3909593 View commit details
    Browse the repository at this point in the history

  12. Merge branch 'release/6.0.1xx' into merges/release/6.0.1xx-preview4-t… 

    …o-release/6.0.1xx
    @jmarolf
    jmarolf authored Apr 23, 2021
    Configuration menu
    Copy the full SHA
    0e884fe View commit details
    Browse the repository at this point in the history

  13. Merge pull request #5048 from dotnet/merges/release/6.0.1xx-preview4-… 

    …to-release/6.0.1xx

Merge release/6.0.1xx-preview4 to release/6.0.1xx
    @jmarolf
    jmarolf authored Apr 23, 2021
    Configuration menu
    Copy the full SHA
    153c628 View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2021

  1. Apply requested changes 

    - Apply Mavasani's changes
- Remove unused method from fixers
    @NewellClark
    NewellClark committed Apr 24, 2021
    Configuration menu
    Copy the full SHA
    760cd4a View commit details
    Browse the repository at this point in the history

  2. Change ID to CA1845

    @NewellClark
    NewellClark committed Apr 24, 2021
    Configuration menu
    Copy the full SHA
    49894c3 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'release/6.0.1xx-preview4' into use-span-based-concat-an… 

    …alyzer
    @NewellClark
    NewellClark authored Apr 24, 2021
    Configuration menu
    Copy the full SHA
    1cd7b98 View commit details
    Browse the repository at this point in the history

  4. .

    @NewellClark
    NewellClark committed Apr 24, 2021
    Configuration menu
    Copy the full SHA
    e4867b8 View commit details
    Browse the repository at this point in the history

  5. Rebuild xlf files to fix CI

    @NewellClark
    NewellClark committed Apr 24, 2021
    Configuration menu
    Copy the full SHA
    2b71460 View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2021

  1. Add analyzer and code fixer for providing a public parameterless Safe… 

    …Handle constructor.

Outline tests and start filling them in.
    @jkoritzinsky
    jkoritzinsky committed Apr 26, 2021
    Configuration menu
    Copy the full SHA
    998f22f View commit details
    Browse the repository at this point in the history

  2. Fill in the rest of the unit tests.

    @jkoritzinsky
    jkoritzinsky committed Apr 26, 2021
    Configuration menu
    Copy the full SHA
    ba11cf1 View commit details
    Browse the repository at this point in the history

  3. Undo accidental file rename.

    @jkoritzinsky
    jkoritzinsky committed Apr 26, 2021
    Configuration menu
    Copy the full SHA
    f88181e View commit details
    Browse the repository at this point in the history

  4. PR feedback.

    @jkoritzinsky
    jkoritzinsky committed Apr 26, 2021
    Configuration menu
    Copy the full SHA
    9a83408 View commit details
    Browse the repository at this point in the history

  5. Update src/NetAnalyzers/Core/AnalyzerReleases.Unshipped.md 

    Co-authored-by: Youssef Victor <youssefvictor00@gmail.com>
    @jkoritzinsky @Youssef1313
    jkoritzinsky and Youssef1313 committed Apr 26, 2021
    Configuration menu
    Copy the full SHA
    2c5a656 View commit details
    Browse the repository at this point in the history

  6. Coalesce fixer types.

    @jkoritzinsky
    jkoritzinsky committed Apr 26, 2021
    Configuration menu
    Copy the full SHA
    0457275 View commit details
    Browse the repository at this point in the history

  7. Use alternative diagnostic location format.

    @jkoritzinsky
    jkoritzinsky committed Apr 26, 2021
    Configuration menu
    Copy the full SHA
    0a8faf8 View commit details
    Browse the repository at this point in the history

  8. Apply suggestions from code review 

    Co-authored-by: Youssef Victor <youssefvictor00@gmail.com>
    @jkoritzinsky @Youssef1313
    jkoritzinsky and Youssef1313 committed Apr 26, 2021
    Configuration menu
    Copy the full SHA
    0f0d189 View commit details
    Browse the repository at this point in the history

  9. Fix resources based on feedback.

    @jkoritzinsky
    jkoritzinsky committed Apr 26, 2021
    Configuration menu
    Copy the full SHA
    b23c5e0 View commit details
    Browse the repository at this point in the history

  10. Remove extra parameter that seems unneeded.

    @jkoritzinsky
    jkoritzinsky committed Apr 26, 2021
    Configuration menu
    Copy the full SHA
    174693a View commit details
    Browse the repository at this point in the history

  11. Regenerate generated files.

    @jkoritzinsky
    jkoritzinsky committed Apr 26, 2021
    Configuration menu
    Copy the full SHA
    39f2d7c View commit details
    Browse the repository at this point in the history

  12. Remove periods.

    @jkoritzinsky
    jkoritzinsky committed Apr 26, 2021
    Configuration menu
    Copy the full SHA
    c227a63 View commit details
    Browse the repository at this point in the history

  13. Update xlf

    @jkoritzinsky
    jkoritzinsky committed Apr 26, 2021
    Configuration menu
    Copy the full SHA
    fcbb1ad View commit details
    Browse the repository at this point in the history

Commits on Apr 27, 2021

  1. Add additional test with larger inheritance tree.

    @jkoritzinsky
    jkoritzinsky committed Apr 27, 2021
    Configuration menu
    Copy the full SHA
    c0fbfc1 View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2021

  1. Merge pull request #5076 from dotnet/merges/main-to-release/6.0.1xx 

    Merge main to release/6.0.1xx
    @jmarolf
    jmarolf authored Apr 29, 2021
    Configuration menu
    Copy the full SHA
    dee8691 View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2021

  1. Merge pull request #5078 from dotnet/merges/main-to-release/6.0.1xx 

    Merge main to release/6.0.1xx
    @jmarolf
    jmarolf authored Apr 30, 2021
    Configuration menu
    Copy the full SHA
    fedf0ae View commit details
    Browse the repository at this point in the history

Commits on May 6, 2021

  1. Merge pull request #5085 from dotnet/merges/main-to-release/6.0.1xx 

    Merge main to release/6.0.1xx
    @jmarolf
    jmarolf authored May 6, 2021
    Configuration menu
    Copy the full SHA
    068ae34 View commit details
    Browse the repository at this point in the history

Commits on May 8, 2021

  1. Change ID to CA1846

    @NewellClark
    NewellClark committed May 8, 2021
    Configuration menu
    Copy the full SHA
    bf3e977 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'release/6.0.1xx-preview4' into prefer-AsSpan-over-Subst… 

    …ring-analyzer
    @NewellClark
    NewellClark authored May 8, 2021
    Configuration menu
    Copy the full SHA
    b79616d View commit details
    Browse the repository at this point in the history

  3. Rebuild resource files

    @NewellClark
    NewellClark committed May 8, 2021
    Configuration menu
    Copy the full SHA
    4cc4704 View commit details
    Browse the repository at this point in the history

  4. Fix CI

    @NewellClark
    NewellClark committed May 8, 2021
    Configuration menu
    Copy the full SHA
    380d1c4 View commit details
    Browse the repository at this point in the history

  5. .

    @NewellClark
    NewellClark committed May 8, 2021
    Configuration menu
    Copy the full SHA
    1c1f94c View commit details
    Browse the repository at this point in the history

Commits on May 9, 2021

  1. Force xlf update

    @NewellClark
    NewellClark committed May 9, 2021
    Configuration menu
    Copy the full SHA
    36acacd View commit details
    Browse the repository at this point in the history

Commits on May 10, 2021

  1. Import System namespace correctly 

    Use case-insensitive string comparison to import System namespace in the VB fixer.
    @NewellClark
    NewellClark committed May 10, 2021
    Configuration menu
    Copy the full SHA
    268acdc View commit details
    Browse the repository at this point in the history

  2. Allow affirmative checks with else-clause

    @NewellClark
    NewellClark committed May 10, 2021
    Configuration menu
    Copy the full SHA
    f10db94 View commit details
    Browse the repository at this point in the history

  3. Add VB test

    @NewellClark
    NewellClark committed May 10, 2021
    Configuration menu
    Copy the full SHA
    688388c View commit details
    Browse the repository at this point in the history

Commits on May 11, 2021

  1. Merge main to release/6.0.1xx (#5090) 

    * Add localization from OneLocBuild (2021-04-27)

* Merge conflicts (#5079)

* Add localization from OneLocBuild (2021-04-28)

Co-authored-by: Jon Fortescue <jonfortescue@protonmail.com>
Co-authored-by: Buyaa Namnan <bunamnan@microsoft.com>
Co-authored-by: Sam Harwell <sam@tunnelvisionlabs.com>
Co-authored-by: Jonathon Marolf <jmarolf@users.noreply.github.com>
    @dotnet-bot @jonfortescue
    @buyaa-n @sharwell @jmarolf
    5 people authored May 11, 2021
    Configuration menu
    Copy the full SHA
    516079f View commit details
    Browse the repository at this point in the history

Commits on May 12, 2021

  1. CA1416 Support custom guard members annotated with guard attributes (#… 

    …5087)

* Support custom guard with attributes
    @buyaa-n
    buyaa-n authored May 12, 2021
    Configuration menu
    Copy the full SHA
    15dd5af View commit details
    Browse the repository at this point in the history

Commits on May 13, 2021

  1. Preserve trivia 

    - Add tests ensuring trivia is preserved
- Ensure trivia is preserved
    @NewellClark
    NewellClark committed May 13, 2021
    Configuration menu
    Copy the full SHA
    369b057 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'release/6.0.1xx-preview4' into use-CancellationToken-Th… 

    …rowIfCancellationRequested
    @NewellClark
    NewellClark authored May 13, 2021
    Configuration menu
    Copy the full SHA
    bcb2ec9 View commit details
    Browse the repository at this point in the history

Commits on May 14, 2021

  1. Fix CI

    @NewellClark
    NewellClark committed May 14, 2021
    Configuration menu
    Copy the full SHA
    4d890bd View commit details
    Browse the repository at this point in the history

  2. Add shared attribute to fixer

    @NewellClark
    NewellClark committed May 14, 2021
    Configuration menu
    Copy the full SHA
    a551291 View commit details
    Browse the repository at this point in the history

Commits on May 17, 2021

  1. Apply suggested changes 

    Fix possible crash when primitive types can't be loaded
    @NewellClark
    NewellClark committed May 17, 2021
    Configuration menu
    Copy the full SHA
    f70c6d8 View commit details
    Browse the repository at this point in the history

  2. Update src/NetAnalyzers/Core/AnalyzerReleases.Unshipped.md 

    Co-authored-by: Manish Vasani <mavasani@microsoft.com>
    @NewellClark @mavasani
    NewellClark and mavasani authored May 17, 2021
    Configuration menu
    Copy the full SHA
    092b95d View commit details
    Browse the repository at this point in the history

  3. Update src/NetAnalyzers/Core/AnalyzerReleases.Unshipped.md 

    Co-authored-by: Manish Vasani <mavasani@microsoft.com>
    @NewellClark @mavasani
    NewellClark and mavasani authored May 17, 2021
    Configuration menu
    Copy the full SHA
    24f0017 View commit details
    Browse the repository at this point in the history

  4. Update src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/Runtime/UseC… 

    …ancellationTokenThrowIfCancellationRequested.cs

Co-authored-by: Manish Vasani <mavasani@microsoft.com>
    @NewellClark @mavasani
    NewellClark and mavasani authored May 17, 2021
    Configuration menu
    Copy the full SHA
    3a4b0c8 View commit details
    Browse the repository at this point in the history

  5. Simplify fixer

    @NewellClark
    NewellClark committed May 17, 2021
    Configuration menu
    Copy the full SHA
    ea967fe View commit details
    Browse the repository at this point in the history

  6. Merge conflicts

    @buyaa-n
    buyaa-n committed May 17, 2021
    Configuration menu
    Copy the full SHA
    2cc221b View commit details
    Browse the repository at this point in the history

  7. Fix lint error

    @buyaa-n
    buyaa-n committed May 17, 2021
    Configuration menu
    Copy the full SHA
    970d7bb View commit details
    Browse the repository at this point in the history

  8. Merge pull request #5097 from dotnet/merges/main-to-release/6.0.1xx 

    Merge main to release/6.0.1xx
    @jmarolf
    jmarolf authored May 17, 2021
    Configuration menu
    Copy the full SHA
    1c29307 View commit details
    Browse the repository at this point in the history

  9. Create files and tests

    @NewellClark
    NewellClark committed May 17, 2021
    Configuration menu
    Copy the full SHA
    78d78e9 View commit details
    Browse the repository at this point in the history

Commits on May 18, 2021

  1. Merge pull request #4764 from NewellClark/use-span-based-concat-analyzer 

    (3/4) Use Span-Based String Concat Analyzer and Fixer
    @mavasani
    mavasani authored May 18, 2021
    Configuration menu
    Copy the full SHA
    0f43809 View commit details
    Browse the repository at this point in the history

  2. Use simple names in diagnostic messages 

    - Remove usages of `MinimallyQualifiedFormat`
- Change message so it makes sense with simple names
    @NewellClark
    NewellClark committed May 18, 2021
    Configuration menu
    Copy the full SHA
    94ee770 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'release/6.0.1xx' into issue-33789

    @NewellClark
    NewellClark authored May 18, 2021
    Configuration menu
    Copy the full SHA
    4d7967b View commit details
    Browse the repository at this point in the history

  4. Merge pull request #4726 from NewellClark/issue-33789 

    (2/4) Override Stream ReadAsync/WriteAsync Analyzer
    @mavasani
    mavasani authored May 18, 2021
    Configuration menu
    Copy the full SHA
    4bda814 View commit details
    Browse the repository at this point in the history

  5. Update src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/MicrosoftNet… 

    …CoreAnalyzersResources.resx

Co-authored-by: Manish Vasani <mavasani@microsoft.com>
    @NewellClark @mavasani
    NewellClark and mavasani authored May 18, 2021
    Configuration menu
    Copy the full SHA
    a8e5a51 View commit details
    Browse the repository at this point in the history

  6. Apply suggested changes

    @NewellClark
    NewellClark committed May 18, 2021
    Configuration menu
    Copy the full SHA
    74bfc25 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'release/6.0.1xx' into prefer-AsSpan-over-Substring-anal… 

    …yzer
    @NewellClark
    NewellClark authored May 18, 2021
    Configuration menu
    Copy the full SHA
    053b2c4 View commit details
    Browse the repository at this point in the history

  8. Run msbuild to fix CI

    @NewellClark
    NewellClark committed May 18, 2021
    Configuration menu
    Copy the full SHA
    9574d85 View commit details
    Browse the repository at this point in the history

  9. Merge branch 'release/6.0.1xx' into use-CancellationToken-ThrowIfCanc… 

    …ellationRequested
    @NewellClark
    NewellClark authored May 18, 2021
    Configuration menu
    Copy the full SHA
    f09b43e View commit details
    Browse the repository at this point in the history

  10. Merge branch 'release/6.0.1xx' of github.com:dotnet/roslyn-analyzers … 

    …into safehandle-analyzer-and-fixer
    @jkoritzinsky
    jkoritzinsky committed May 18, 2021
    Configuration menu
    Copy the full SHA
    064c79b View commit details
    Browse the repository at this point in the history

Commits on May 19, 2021

  1. Implement analyzer and fixer 

    Add GetFirstOrDefaultMemberWithParameterTypes to utilities
    @NewellClark
    NewellClark committed May 19, 2021
    Configuration menu
    Copy the full SHA
    c3408c7 View commit details
    Browse the repository at this point in the history

  2. Run msbuild

    @NewellClark
    NewellClark committed May 19, 2021
    Configuration menu
    Copy the full SHA
    6e503b6 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'dotnet/release/6.0.1xx' into #45552-use… 

    …-string-equals-over-string-compare
    @NewellClark
    NewellClark committed May 19, 2021
    Configuration menu
    Copy the full SHA
    13ff0a4 View commit details
    Browse the repository at this point in the history

  4. Fix build warnings

    @NewellClark
    NewellClark committed May 19, 2021
    Configuration menu
    Copy the full SHA
    1963ab1 View commit details
    Browse the repository at this point in the history

  5. Fix more build warnings 

    Remove all references to SyntaxGenerator from analyzer class
    @NewellClark
    NewellClark committed May 19, 2021
    Configuration menu
    Copy the full SHA
    db69ec2 View commit details
    Browse the repository at this point in the history

  6. Apply suggested changes

    @NewellClark
    NewellClark committed May 19, 2021
    Configuration menu
    Copy the full SHA
    3f76529 View commit details
    Browse the repository at this point in the history

  7. Restructure analyzer and fixer 

    Analyzer and fixer were intertwined in unhealthy ways that also caused CI failures.
    @NewellClark
    NewellClark committed May 19, 2021
    Configuration menu
    Copy the full SHA
    7883135 View commit details
    Browse the repository at this point in the history

  8. Run msbuild

    @NewellClark
    NewellClark committed May 19, 2021
    Configuration menu
    Copy the full SHA
    0c0d788 View commit details
    Browse the repository at this point in the history

  9. Merge pull request #5113 from dotnet/merges/main-to-release/6.0.1xx 

    Merge main to release/6.0.1xx
    @jmarolf
    jmarolf authored May 19, 2021
    Configuration menu
    Copy the full SHA
    3376846 View commit details
    Browse the repository at this point in the history

Commits on May 20, 2021

  1. Update Versions.props 

    move release/6.0.1xx to preview 6
    @jmarolf
    jmarolf authored May 20, 2021
    Configuration menu
    Copy the full SHA
    f0558eb View commit details
    Browse the repository at this point in the history

  2. Merge pull request #5118 from dotnet/merges/main-to-release/6.0.1xx 

    Merge main to release/6.0.1xx
    @mavasani
    mavasani authored May 20, 2021
    Configuration menu
    Copy the full SHA
    2304afe View commit details
    Browse the repository at this point in the history

  3. Apply suggestions from code review 

    Co-authored-by: Manish Vasani <mavasani@microsoft.com>
    @NewellClark @mavasani
    NewellClark and mavasani authored May 20, 2021
    Configuration menu
    Copy the full SHA
    05f8773 View commit details
    Browse the repository at this point in the history

  4. Apply suggested changes

    @NewellClark
    NewellClark committed May 20, 2021
    Configuration menu
    Copy the full SHA
    34274f9 View commit details
    Browse the repository at this point in the history

  5. Merge remote-tracking branch 'dotnet/release/6.0.1xx' into #45552-use… 

    …-string-equals-over-string-compare
    @NewellClark
    NewellClark committed May 20, 2021
    Configuration menu
    Copy the full SHA
    5f5b92d View commit details
    Browse the repository at this point in the history

  6. Merge pull request #4864 from NewellClark/use-CancellationToken-Throw… 

    …IfCancellationRequested

Use cancellation token throw if cancellation requested
    @mavasani
    mavasani authored May 20, 2021
    Configuration menu
    Copy the full SHA
    92a247f View commit details
    Browse the repository at this point in the history

  7. Merge branch 'release/6.0.1xx' into prefer-AsSpan-over-Substring-anal… 

    …yzer
    @NewellClark
    NewellClark authored May 20, 2021
    Configuration menu
    Copy the full SHA
    34dc2d6 View commit details
    Browse the repository at this point in the history

  8. Change diagnostic id to CA2251

    @NewellClark
    NewellClark committed May 20, 2021
    Configuration menu
    Copy the full SHA
    579f683 View commit details
    Browse the repository at this point in the history

  9. Merge remote-tracking branch 'dotnet/release/6.0.1xx' into #45552-use… 

    …-string-equals-over-string-compare
    @NewellClark
    NewellClark committed May 20, 2021
    Configuration menu
    Copy the full SHA
    390f6fa View commit details
    Browse the repository at this point in the history

Commits on May 21, 2021

  1. Merge pull request #5119 from dotnet/merges/main-to-release/6.0.1xx 

    Merge main to release/6.0.1xx
    @mavasani
    mavasani authored May 21, 2021
    Configuration menu
    Copy the full SHA
    1d505a7 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #4806 from NewellClark/prefer-AsSpan-over-Substrin… 

    …g-analyzer

(4/4) Prefer 'AsSpan' over 'Substring' analyzer
    @mavasani
    mavasani authored May 21, 2021
    Configuration menu
    Copy the full SHA
    5ee4a10 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'release/6.0.1xx' into #45552-use-string-equals-over-str… 

    …ing-compare
    @NewellClark
    NewellClark authored May 21, 2021
    Configuration menu
    Copy the full SHA
    4f0881f View commit details
    Browse the repository at this point in the history

  4. Don't access the semantic model directly inside RegisterCodeFixesAsync.

    @jkoritzinsky
    jkoritzinsky committed May 21, 2021
    Configuration menu
    Copy the full SHA
    019c4da View commit details
    Browse the repository at this point in the history

  5. Use string.Empty instead of null

    @jkoritzinsky
    jkoritzinsky committed May 21, 2021
    Configuration menu
    Copy the full SHA
    c6acedb View commit details
    Browse the repository at this point in the history

  6. Apply suggested changes

    @NewellClark
    NewellClark committed May 21, 2021
    Configuration menu
    Copy the full SHA
    2371844 View commit details
    Browse the repository at this point in the history

  7. Assert if symbols can't be loaded in fixer

    @NewellClark
    NewellClark committed May 21, 2021
    Configuration menu
    Copy the full SHA
    6562d14 View commit details
    Browse the repository at this point in the history

Commits on May 23, 2021

  1. Merge pull request #5116 from NewellClark/#45552-use-string-equals-ov… 

    …er-string-compare

#45552 use string equals over string compare
    @ryzngard
    ryzngard authored May 23, 2021
    Configuration menu
    Copy the full SHA
    d464b5f View commit details
    Browse the repository at this point in the history

Commits on May 24, 2021

  1. Merge branch 'release/6.0.1xx' of github.com:dotnet/roslyn-analyzers … 

    …into safehandle-analyzer-and-fixer
    @jkoritzinsky
    jkoritzinsky committed May 24, 2021
    Configuration menu
    Copy the full SHA
    483e77e View commit details
    Browse the repository at this point in the history

  2. Merge pull request #5043 from jkoritzinsky/safehandle-analyzer-and-fixer 

    Implement Analyzer and best-effort Code Fix for SafeHandle Public Parameterless Constructor guidance.
    @mavasani
    mavasani authored May 24, 2021
    Configuration menu
    Copy the full SHA
    a43657b View commit details
    Browse the repository at this point in the history

Commits on May 27, 2021

  1. [CA1416] Targeted build attributes can be overriden in cross platform… 

    … assemblies (#5117)

* Targeted build attributes can be overriden in cross platform assemblies
    @buyaa-n
    buyaa-n authored May 27, 2021
    Configuration menu
    Copy the full SHA
    5078028 View commit details
    Browse the repository at this point in the history

Commits on May 29, 2021

  1. Implement CA1847 - Use string.Contains(char) whenever possible 

    Fan out to different implementations for VB and CSharp since named argument have no IOperation abstraction
    @MeikTranel
    MeikTranel committed May 29, 2021
    Configuration menu
    Copy the full SHA
    cb17df3 View commit details
    Browse the repository at this point in the history

Commits on Jun 1, 2021

  1. Merge pull request #4908 from MeikTranel/StringContainsCodeFix 

    Add Analyzer & Codefix - CA1847 -  Use String.Contains(Char) instead of String.Contains(String) with single characters
    @mavasani
    mavasani authored Jun 1, 2021
    Configuration menu
    Copy the full SHA
    6db81f2 View commit details
    Browse the repository at this point in the history

Commits on Jun 19, 2021

  1. Merge remote-tracking branch 'upstream/main' into merges/main-to-rele… 

    …ase/6.0.1xx
    @jmarolf
    jmarolf committed Jun 19, 2021
    Configuration menu
    Copy the full SHA
    0c66366 View commit details
    Browse the repository at this point in the history

  2. Update Versions.props

    @jmarolf
    jmarolf authored Jun 19, 2021
    Configuration menu
    Copy the full SHA
    98989fd View commit details
    Browse the repository at this point in the history

  3. Update Versions.props

    @jmarolf
    jmarolf authored Jun 19, 2021
    Configuration menu
    Copy the full SHA
    710e6c5 View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2021

  1. Merge branch 'release/6.0.1xx' into merges/release/6.0.1xx-preview7-t… 

    …o-release/6.0.1xx
    @jmarolf
    jmarolf authored Jun 20, 2021
    Configuration menu
    Copy the full SHA
    e0be380 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #5121 from dotnet/merges/main-to-release/6.0.1xx

    @jmarolf
    jmarolf authored Jun 20, 2021
    Configuration menu
    Copy the full SHA
    ffbc0f1 View commit details
    Browse the repository at this point in the history

  3. Merge pull request #5156 from dotnet/merges/release/6.0.1xx-preview7-… 

    …to-release/6.0.1xx

Merge release/6.0.1xx-preview7 to release/6.0.1xx
    @jmarolf
    jmarolf authored Jun 20, 2021
    Configuration menu
    Copy the full SHA
    fcddb77 View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2021

  1. Merge pull request #5164 from dotnet/merges/main-to-release/6.0.1xx 

    Merge main to release/6.0.1xx
    @mavasani
    mavasani authored Jun 24, 2021
    Configuration menu
    Copy the full SHA
    c801eb6 View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2021

  1. Merge remote-tracking branch 'upstream/main' into merges/main-to-rele… 

    …ase/6.0.1xx
    @jmarolf
    jmarolf committed Jul 1, 2021
    Configuration menu
    Copy the full SHA
    964d9d9 View commit details
    Browse the repository at this point in the history

  2. fixup merge conflicts

    @jmarolf
    jmarolf committed Jul 1, 2021
    Configuration menu
    Copy the full SHA
    6dcd58e View commit details
    Browse the repository at this point in the history

  3. fixing errors given by the test framework about editorconfig files be… 

    …ing additional files
    @jmarolf
    jmarolf committed Jul 1, 2021
    Configuration menu
    Copy the full SHA
    3d710d4 View commit details
    Browse the repository at this point in the history

  4. Merge pull request #5167 from dotnet/merges/main-to-release/6.0.1xx

    @jmarolf
    jmarolf authored Jul 1, 2021
    Configuration menu
    Copy the full SHA
    ac63f73 View commit details
    Browse the repository at this point in the history

Commits on Jul 2, 2021

  1. Merge pull request #5196 from dotnet/merges/main-to-release/6.0.1xx

    @jmarolf
    jmarolf authored Jul 2, 2021
    Configuration menu
    Copy the full SHA
    1385777 View commit details
    Browse the repository at this point in the history

Commits on Jul 6, 2021

  1. Merge remote-tracking branch 'upstream/main' into merges/main-to-rele… 

    …ase/6.0.1xx
    @jmarolf
    jmarolf committed Jul 6, 2021
    Configuration menu
    Copy the full SHA
    d0234bc View commit details
    Browse the repository at this point in the history

  2. update baseline for 6.0.x

    @jmarolf
    jmarolf committed Jul 6, 2021
    Configuration menu
    Copy the full SHA
    19faf78 View commit details
    Browse the repository at this point in the history

  3. Merge pull request #5204 from dotnet/merges/main-to-release/6.0.1xx

    @jmarolf
    jmarolf authored Jul 6, 2021
    Configuration menu
    Copy the full SHA
    77c6f07 View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2021

  1. Merge remote-tracking branch 'upstream/main' into merges/main-to-rele… 

    …ase/6.0.1xx
    @jmarolf
    jmarolf committed Jul 11, 2021
    Configuration menu
    Copy the full SHA
    c8fb50f View commit details
    Browse the repository at this point in the history

  2. Merge pull request #5211 from dotnet/merges/main-to-release/6.0.1xx 

    Merge main to release/6.0.1xx
    @jmarolf
    jmarolf authored Jul 11, 2021
    Configuration menu
    Copy the full SHA
    5e66ca8 View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2021

  1. Analyzer to detect RequiresPreviewFeatures attribute (#5155) 

    * Detect RequiresPreviewFeaturesAttribute in source

* Create new rules
    Prashanth Govindarajan authored Jul 12, 2021
    Configuration menu
    Copy the full SHA
    1e2ab23 View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2021

  1. Merge pull request #5249 from dotnet/merges/main-to-release/6.0.1xx 

    Merge main to release/6.0.1xx
    @dotnet-bot
    dotnet-bot authored Jul 16, 2021
    Configuration menu
    Copy the full SHA
    7e82240 View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2021

  1. Remove dead code in CA1069 analyzer (#5253)

    @RikkiGibson @steveberdy
    RikkiGibson authored and steveberdy committed Aug 17, 2021
    Configuration menu
    Copy the full SHA
    dad58d5 View commit details
    Browse the repository at this point in the history

  2. Delete IDE dispose analyzer rules 

    The IDE dispose analyzer rules have been deleted from Roslyn:

dotnet/roslyn@eeba499
    @xtqqczze @steveberdy
    xtqqczze authored and steveberdy committed Aug 17, 2021
    Configuration menu
    Copy the full SHA
    602fa2c View commit details
    Browse the repository at this point in the history

  3. CA1839 analyzer started 

    # Conflicts:
#	src/NetAnalyzers/Core/AnalyzerReleases.Unshipped.md
#	src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/xlf/MicrosoftNetCoreAnalyzersResources.cs.xlf
#	src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/xlf/MicrosoftNetCoreAnalyzersResources.de.xlf
#	src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/xlf/MicrosoftNetCoreAnalyzersResources.es.xlf
#	src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/xlf/MicrosoftNetCoreAnalyzersResources.fr.xlf
#	src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/xlf/MicrosoftNetCoreAnalyzersResources.it.xlf
#	src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/xlf/MicrosoftNetCoreAnalyzersResources.ja.xlf
#	src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/xlf/MicrosoftNetCoreAnalyzersResources.ko.xlf
#	src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/xlf/MicrosoftNetCoreAnalyzersResources.pl.xlf
#	src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/xlf/MicrosoftNetCoreAnalyzersResources.pt-BR.xlf
#	src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/xlf/MicrosoftNetCoreAnalyzersResources.ru.xlf
#	src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/xlf/MicrosoftNetCoreAnalyzersResources.tr.xlf
#	src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/xlf/MicrosoftNetCoreAnalyzersResources.zh-Hans.xlf
#	src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/xlf/MicrosoftNetCoreAnalyzersResources.zh-Hant.xlf
#	src/Utilities/Compiler/DiagnosticCategoryAndIdRanges.txt
    @steveberdy
    steveberdy committed Aug 17, 2021
    Configuration menu
    Copy the full SHA
    0916e5f View commit details
    Browse the repository at this point in the history

  4. CA1839 fixer code action added

    @steveberdy
    steveberdy committed Aug 17, 2021
    Configuration menu
    Copy the full SHA
    a7c910e View commit details
    Browse the repository at this point in the history

  5. Edits to AvoidConstArrays.Fixer.cs

    @steveberdy
    steveberdy committed Aug 17, 2021
    Configuration menu
    Copy the full SHA
    a3e52bc View commit details
    Browse the repository at this point in the history

  6. Fixed roslyn warnings

    @steveberdy
    steveberdy committed Aug 17, 2021
    Configuration menu
    Copy the full SHA
    dd7d8fa View commit details
    Browse the repository at this point in the history

  7. Debugged to properly create the diagnostic

    @steveberdy
    steveberdy committed Aug 17, 2021
    Configuration menu
    Copy the full SHA
    7d77c01 View commit details
    Browse the repository at this point in the history

  8. Remove some empty statements

    @Evangelink @steveberdy
    Evangelink authored and steveberdy committed Aug 17, 2021
    Configuration menu
    Copy the full SHA
    775d81c View commit details
    Browse the repository at this point in the history

  9. Initial add of richnav indexing

    @brianaeng @steveberdy
    brianaeng authored and steveberdy committed Aug 17, 2021
    Configuration menu
    Copy the full SHA
    478d064 View commit details
    Browse the repository at this point in the history

  10. Update yml spacing

    @brianaeng @steveberdy
    brianaeng authored and steveberdy committed Aug 17, 2021
    Configuration menu
    Copy the full SHA
    6ed614c View commit details
    Browse the repository at this point in the history

  11. Remove unauthorized settings

    @brianaeng @steveberdy
    brianaeng authored and steveberdy committed Aug 17, 2021
    Configuration menu
    Copy the full SHA
    eb4f6f5 View commit details
    Browse the repository at this point in the history

  12. Update pool

    @brianaeng @steveberdy
    brianaeng authored and steveberdy committed Aug 17, 2021
    Configuration menu
    Copy the full SHA
    5199ffe View commit details
    Browse the repository at this point in the history

  13. Attempt to fix test step in build pipeline

    @brianaeng @steveberdy
    brianaeng authored and steveberdy committed Aug 17, 2021
    Configuration menu
    Copy the full SHA
    4c87a2e View commit details
    Browse the repository at this point in the history

  14. Add richnav nuget source

    @brianaeng @steveberdy
    brianaeng authored and steveberdy committed Aug 17, 2021
    Configuration menu
    Copy the full SHA
    f29e807 View commit details
    Browse the repository at this point in the history

  15. RichNav run worked in main yml -- removing from there and copying it … 

    …to richnav solo yml
    @brianaeng @steveberdy
    brianaeng authored and steveberdy committed Aug 17, 2021
    Configuration menu
    Copy the full SHA
    e570e6b View commit details
    Browse the repository at this point in the history

  16. Remove added whitespace

    @brianaeng @steveberdy
    brianaeng authored and steveberdy committed Aug 17, 2021
    Configuration menu
    Copy the full SHA
    c6b009c View commit details
    Browse the repository at this point in the history

  17. Remove unused vars, rename displayName for clarity

    @brianaeng @steveberdy
    brianaeng authored and steveberdy committed Aug 17, 2021
    Configuration menu
    Copy the full SHA
    bee6492 View commit details
    Browse the repository at this point in the history

  18. Loc/zh-hans: 过载 -> 重载

    @imba-tjd @steveberdy
    imba-tjd authored and steveberdy committed Aug 17, 2021
    Configuration menu
    Copy the full SHA
    b264852 View commit details
    Browse the repository at this point in the history

  19. Install vs-threading analyzers

    @sharwell @steveberdy
    sharwell authored and steveberdy committed Aug 17, 2021
    Configuration menu
    Copy the full SHA
    e539d7d View commit details
    Browse the repository at this point in the history

  20. Update RelaxTestNamingSuppressor to recognize BenchmarkAttribute

    @sharwell @steveberdy
    sharwell authored and steveberdy committed Aug 17, 2021
    Configuration menu
    Copy the full SHA
    128c94e View commit details
    Browse the repository at this point in the history

  21. Add missing FactAttribute

    @sharwell @steveberdy
    sharwell authored and steveberdy committed Aug 17, 2021
    Configuration menu
    Copy the full SHA
    54c8c41 View commit details
    Browse the repository at this point in the history

  22. update headers

    @jmarolf @steveberdy
    jmarolf authored and steveberdy committed Aug 17, 2021
    Configuration menu
    Copy the full SHA
    d302777 View commit details
    Browse the repository at this point in the history

  23. Refactor tests to use non-obselete location API

    @Evangelink @steveberdy
    Evangelink authored and steveberdy committed Aug 17, 2021
    Configuration menu
    Copy the full SHA
    66cb185 View commit details
    Browse the repository at this point in the history

  24. handle params array in the argument list 

    fixes #4842
    @jmarolf @steveberdy
    jmarolf authored and steveberdy committed Aug 17, 2021
    Configuration menu
    Copy the full SHA
    35ad7ce View commit details
    Browse the repository at this point in the history

  25. Update src/NetAnalyzers/UnitTests/Microsoft.NetCore.Analyzers/Runtime… 

    …/ForwardCancellationTokenToInvocationsTests.cs

Co-authored-by: Youssef Victor <youssefvictor00@gmail.com>
    @jmarolf @Youssef1313 @steveberdy
    2 people authored and steveberdy committed Aug 17, 2021
    Configuration menu
    Copy the full SHA
    3651a9f View commit details
    Browse the repository at this point in the history

  26. remove unused parameters

    @jmarolf @steveberdy
    jmarolf authored and steveberdy committed Aug 17, 2021
    Configuration menu
    Copy the full SHA
    db392cc View commit details
    Browse the repository at this point in the history

  27. rename types

    @jmarolf @steveberdy
    jmarolf authored and steveberdy committed Aug 17, 2021
    Configuration menu
    Copy the full SHA
    04bc47f View commit details
    Browse the repository at this point in the history

  28. rename files

    @jmarolf @steveberdy
    jmarolf authored and steveberdy committed Aug 17, 2021
    Configuration menu
    Copy the full SHA
    41a0a2c View commit details
    Browse the repository at this point in the history

  29. manually contruct array in VB case

    @jmarolf @steveberdy
    jmarolf authored and steveberdy committed Aug 17, 2021
    Configuration menu
    Copy the full SHA
    73edf91 View commit details
    Browse the repository at this point in the history

  30. remove unused using

    @jmarolf @steveberdy
    jmarolf authored and steveberdy committed Aug 17, 2021
    Configuration menu
    Copy the full SHA
    e10120a View commit details
    Browse the repository at this point in the history

  31. remove blank line

    @jmarolf @steveberdy
    jmarolf authored and steveberdy committed Aug 17, 2021
    Configuration menu
    Copy the full SHA
    492a901 View commit details
    Browse the repository at this point in the history

  32. Update src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/Runtime/Forw… 

    …ardCancellationTokenToInvocations.Fixer.cs

Co-authored-by: Andrew Hall <ryzngard@live.com>
    @jmarolf @ryzngard @steveberdy
    2 people authored and steveberdy committed Aug 17, 2021
    Configuration menu
    Copy the full SHA
    2a5378f View commit details
    Browse the repository at this point in the history

  33. fixing formatting

    @jmarolf @steveberdy
    jmarolf authored and steveberdy committed Aug 17, 2021
    Configuration menu
    Copy the full SHA
    4fe999d View commit details
    Browse the repository at this point in the history

  34. update headers

    @jmarolf @steveberdy
    jmarolf authored and steveberdy committed Aug 17, 2021
    Configuration menu
    Copy the full SHA
    23ae553 View commit details
    Browse the repository at this point in the history

  35. use preview language version

    @jmarolf @steveberdy
    jmarolf authored and steveberdy committed Aug 17, 2021
    Configuration menu
    Copy the full SHA
    77cb72a View commit details
    Browse the repository at this point in the history

  36. prefer is not null to is object

    @jmarolf @steveberdy
    jmarolf authored and steveberdy committed Aug 17, 2021
    Configuration menu
    Copy the full SHA
    abe363c View commit details
    Browse the repository at this point in the history

  37. fixup rebase

    @jmarolf @steveberdy
    jmarolf authored and steveberdy committed Aug 17, 2021
    Configuration menu
    Copy the full SHA
    b87a9f3 View commit details
    Browse the repository at this point in the history

  38. Update license headers in analyzer and tests

    @steveberdy
    steveberdy committed Aug 17, 2021
    Configuration menu
    Copy the full SHA
    0947751 View commit details
    Browse the repository at this point in the history

  39. Remove half-checked-in submodule.

    @crummel @steveberdy
    crummel authored and steveberdy committed Aug 17, 2021
    Configuration menu
    Copy the full SHA
    e8f8f70 View commit details
    Browse the repository at this point in the history

  40. Added comments and more unit tests

    @steveberdy
    steveberdy committed Aug 17, 2021
    Configuration menu
    Copy the full SHA
    5eaffda View commit details
    Browse the repository at this point in the history

  41. Update csharp unit tests for analyzer

    @steveberdy
    steveberdy committed Aug 17, 2021
    Configuration menu
    Copy the full SHA
    9b36c18 View commit details
    Browse the repository at this point in the history

  42. Drafted code fixer and added unit tests

    @steveberdy
    steveberdy committed Aug 17, 2021
    Configuration menu
    Copy the full SHA
    790f06b View commit details
    Browse the repository at this point in the history

  43. Update VerifyCS and VerifyVB aliases to include the fixer class

    @steveberdy
    steveberdy committed Aug 17, 2021
    Configuration menu
    Copy the full SHA
    c3a4cff View commit details
    Browse the repository at this point in the history

  44. Update code fix tests

    @steveberdy
    steveberdy committed Aug 17, 2021
    Configuration menu
    Copy the full SHA
    0ef4bec View commit details
    Browse the repository at this point in the history

  45. Update VB test code

    @steveberdy
    steveberdy committed Aug 17, 2021
    Configuration menu
    Copy the full SHA
    d6eb2f7 View commit details
    Browse the repository at this point in the history

  46. Clean up extract method

    @steveberdy
    steveberdy committed Aug 17, 2021
    Configuration menu
    Copy the full SHA
    73d9891 View commit details
    Browse the repository at this point in the history

  47. Refactored ISymbol.GetContainingMethod as an extension method

    @steveberdy
    steveberdy committed Aug 17, 2021
    Configuration menu
    Copy the full SHA
    a19dc91 View commit details
    Browse the repository at this point in the history

  48. Refactored extraction call

    @steveberdy
    steveberdy committed Aug 17, 2021
    Configuration menu
    Copy the full SHA
    e331702 View commit details
    Browse the repository at this point in the history

  49. [refactor] test's location

    @get-me-power @steveberdy
    get-me-power authored and steveberdy committed Aug 17, 2021
    Configuration menu
    Copy the full SHA
    5ff9719 View commit details
    Browse the repository at this point in the history

  50. [delete] Test's api 

    GetCSharpResultAt(int line, int startColumn, int endColumn, DiagnosticDescriptor descriptor, string bannedMemberName, string message)
GetBasicResultAt(int line, int startColumn, int endColumn, DiagnosticDescriptor descriptor, string bannedMemberName, string message)
    @get-me-power @steveberdy
    get-me-power authored and steveberdy committed Aug 17, 2021
    Configuration menu
    Copy the full SHA
    af26d85 View commit details
    Browse the repository at this point in the history

  51. Update src/Microsoft.CodeAnalysis.BannedApiAnalyzers/UnitTests/Symbol… 

    …IsBannedAnalyzerTests.cs

Co-authored-by: Sam Harwell <sam@tunnelvisionlabs.com>
    @get-me-power @sharwell @steveberdy
    2 people authored and steveberdy committed Aug 17, 2021
    Configuration menu
    Copy the full SHA
    38c924c View commit details
    Browse the repository at this point in the history

  52. [fix] code style

    @get-me-power @steveberdy
    get-me-power authored and steveberdy committed Aug 17, 2021
    Configuration menu
    Copy the full SHA
    8fd73a9 View commit details
    Browse the repository at this point in the history

  53. Added operation kinds for operation registration

    @steveberdy
    steveberdy committed Aug 17, 2021
    Configuration menu
    Copy the full SHA
    2d2a8c0 View commit details
    Browse the repository at this point in the history

  54. Improved analyzer and code fixer

    @steveberdy
    steveberdy committed Aug 17, 2021
    Configuration menu
    Copy the full SHA
    061417f View commit details
    Browse the repository at this point in the history

  55. Analyzer and code fix draft completed

    @steveberdy
    steveberdy committed Aug 17, 2021
    Configuration menu
    Copy the full SHA
    354228f View commit details
    Browse the repository at this point in the history

  56. Refactor or conditions in DoNotUseInsecureDtdProcessingAnalyzer

    @Evangelink @steveberdy
    Evangelink authored and steveberdy committed Aug 17, 2021
    Configuration menu
    Copy the full SHA
    5cf0884 View commit details
    Browse the repository at this point in the history

  57. Cleaned code for more performance

    @steveberdy
    steveberdy committed Aug 17, 2021
    Configuration menu
    Copy the full SHA
    82a9cf1 View commit details
    Browse the repository at this point in the history

  58. More code cleanup

    @steveberdy
    steveberdy committed Aug 17, 2021
    Configuration menu
    Copy the full SHA
    6631760 View commit details
    Browse the repository at this point in the history