Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prefer Dictionary<K, V>.TryAdd(key) over guarded Add(key) #6199

Merged
merged 30 commits into from
Jun 28, 2023
Merged

Prefer Dictionary<K, V>.TryAdd(key) over guarded Add(key) #6199

merged 30 commits into from
Jun 28, 2023

Commits on Oct 9, 2022

  1. Implement analyzer and fixer

    @CollinAlpert
    CollinAlpert committed Oct 9, 2022
    Configuration menu
    Copy the full SHA
    392174c View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2022

  1. Merge branch 'master' into issue_33799 

    # Conflicts:
#	src/NetAnalyzers/Core/AnalyzerReleases.Unshipped.md
    @CollinAlpert
    CollinAlpert committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    49b3759 View commit details
    Browse the repository at this point in the history

  2. Add test.

    @CollinAlpert
    CollinAlpert committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    b4ac501 View commit details
    Browse the repository at this point in the history

Commits on Jan 8, 2023

  1. Merge branch 'master' into issue_33799 

    # Conflicts:
#	src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/MicrosoftNetCoreAnalyzersResources.resx
#	src/NetAnalyzers/Microsoft.CodeAnalysis.NetAnalyzers.md
#	src/NetAnalyzers/Microsoft.CodeAnalysis.NetAnalyzers.sarif
#	src/NetAnalyzers/RulesMissingDocumentation.md
#	src/Utilities/Compiler/DiagnosticCategoryAndIdRanges.txt
    @CollinAlpert
    CollinAlpert committed Jan 8, 2023
    Configuration menu
    Copy the full SHA
    e79bf8f View commit details
    Browse the repository at this point in the history

  2. Fix merge

    @CollinAlpert
    CollinAlpert committed Jan 8, 2023
    Configuration menu
    Copy the full SHA
    b0397f6 View commit details
    Browse the repository at this point in the history

Commits on Jan 10, 2023

  1. Applied misc PR comments.

    @CollinAlpert
    CollinAlpert committed Jan 10, 2023
    Configuration menu
    Copy the full SHA
    3591eac View commit details
    Browse the repository at this point in the history

Commits on Jan 16, 2023

  1. Add failing test cases.

    @CollinAlpert
    CollinAlpert committed Jan 16, 2023
    Configuration menu
    Copy the full SHA
    f2d4f6d View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2023

  1. Merge branch 'master' into issue_33799

    @CollinAlpert
    CollinAlpert committed Jan 17, 2023
    Configuration menu
    Copy the full SHA
    a2d215a View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2023

  1. Fix tests.

    @CollinAlpert
    CollinAlpert committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    06d5482 View commit details
    Browse the repository at this point in the history

Commits on May 9, 2023

  1. Merge branch 'master' into issue_33799 

    # Conflicts:
#	src/NetAnalyzers/Core/AnalyzerReleases.Unshipped.md
#	src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/MicrosoftNetCoreAnalyzersResources.resx
#	src/NetAnalyzers/Microsoft.CodeAnalysis.NetAnalyzers.md
#	src/NetAnalyzers/Microsoft.CodeAnalysis.NetAnalyzers.sarif
#	src/NetAnalyzers/RulesMissingDocumentation.md
#	src/Utilities/Compiler/DiagnosticCategoryAndIdRanges.txt
    @CollinAlpert
    CollinAlpert committed May 9, 2023
    Configuration menu
    Copy the full SHA
    8f6fc45 View commit details
    Browse the repository at this point in the history

Commits on May 10, 2023

  1. Fix merge and remaining test cases

    @CollinAlpert
    CollinAlpert committed May 10, 2023
    Configuration menu
    Copy the full SHA
    04ea1a8 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into issue_33799 

    # Conflicts:
#	src/NetAnalyzers/Core/AnalyzerReleases.Unshipped.md
#	src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/MicrosoftNetCoreAnalyzersResources.resx
#	src/NetAnalyzers/Microsoft.CodeAnalysis.NetAnalyzers.md
#	src/NetAnalyzers/Microsoft.CodeAnalysis.NetAnalyzers.sarif
#	src/NetAnalyzers/RulesMissingDocumentation.md
    @CollinAlpert
    CollinAlpert committed May 10, 2023
    Configuration menu
    Copy the full SHA
    f85e314 View commit details
    Browse the repository at this point in the history

  3. Fix merge conflicts

    @CollinAlpert
    CollinAlpert committed May 10, 2023
    Configuration menu
    Copy the full SHA
    938b4f5 View commit details
    Browse the repository at this point in the history

Commits on May 18, 2023

  1. Consolidate analyzers.

    @CollinAlpert
    CollinAlpert committed May 18, 2023
    Configuration menu
    Copy the full SHA
    c69a4e9 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into issue_33799

    @CollinAlpert
    CollinAlpert committed May 18, 2023
    Configuration menu
    Copy the full SHA
    1c58caa View commit details
    Browse the repository at this point in the history

  3. Fix metadata.

    @CollinAlpert
    CollinAlpert committed May 18, 2023
    Configuration menu
    Copy the full SHA
    7dd1ad6 View commit details
    Browse the repository at this point in the history

Commits on May 23, 2023

  1. Merge branch 'master' into issue_33799 

    # Conflicts:
#	src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/MicrosoftNetCoreAnalyzersResources.resx
#	src/NetAnalyzers/RulesMissingDocumentation.md
    @CollinAlpert
    CollinAlpert committed May 23, 2023
    Configuration menu
    Copy the full SHA
    4a3e7b5 View commit details
    Browse the repository at this point in the history

  2. Revert unrelated changes and changed wording.

    @CollinAlpert
    CollinAlpert committed May 23, 2023
    Configuration menu
    Copy the full SHA
    8c68f28 View commit details
    Browse the repository at this point in the history

  3. Merge fixers

    @CollinAlpert
    CollinAlpert committed May 23, 2023
    Configuration menu
    Copy the full SHA
    ec30fdf View commit details
    Browse the repository at this point in the history

Commits on May 29, 2023

  1. Merge branch 'master' into issue_33799

    @CollinAlpert
    CollinAlpert committed May 29, 2023
    Configuration menu
    Copy the full SHA
    54f8fa9 View commit details
    Browse the repository at this point in the history

  2. Don't warn if no TryAdd method exists.

    @CollinAlpert
    CollinAlpert committed May 29, 2023
    Configuration menu
    Copy the full SHA
    b864ea1 View commit details
    Browse the repository at this point in the history

Commits on Jun 8, 2023

  1. PR comments

    @CollinAlpert
    CollinAlpert committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    e41f11a View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into issue_33799

    @CollinAlpert
    CollinAlpert committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    128ed87 View commit details
    Browse the repository at this point in the history

Commits on Jun 9, 2023

  1. Fix spacing

    @CollinAlpert
    CollinAlpert committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    8298f40 View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2023

  1. Merge branch 'master' into issue_33799 

    # Conflicts:
#	src/NetAnalyzers/Core/AnalyzerReleases.Unshipped.md
#	src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/MicrosoftNetCoreAnalyzersResources.resx
#	src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/xlf/MicrosoftNetCoreAnalyzersResources.cs.xlf
#	src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/xlf/MicrosoftNetCoreAnalyzersResources.de.xlf
#	src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/xlf/MicrosoftNetCoreAnalyzersResources.es.xlf
#	src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/xlf/MicrosoftNetCoreAnalyzersResources.fr.xlf
#	src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/xlf/MicrosoftNetCoreAnalyzersResources.it.xlf
#	src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/xlf/MicrosoftNetCoreAnalyzersResources.ja.xlf
#	src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/xlf/MicrosoftNetCoreAnalyzersResources.ko.xlf
#	src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/xlf/MicrosoftNetCoreAnalyzersResources.pl.xlf
#	src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/xlf/MicrosoftNetCoreAnalyzersResources.pt-BR.xlf
#	src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/xlf/MicrosoftNetCoreAnalyzersResources.ru.xlf
#	src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/xlf/MicrosoftNetCoreAnalyzersResources.tr.xlf
#	src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/xlf/MicrosoftNetCoreAnalyzersResources.zh-Hans.xlf
#	src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/xlf/MicrosoftNetCoreAnalyzersResources.zh-Hant.xlf
#	src/NetAnalyzers/Microsoft.CodeAnalysis.NetAnalyzers.md
#	src/NetAnalyzers/Microsoft.CodeAnalysis.NetAnalyzers.sarif
#	src/NetAnalyzers/RulesMissingDocumentation.md
    @CollinAlpert
    CollinAlpert committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    6631f22 View commit details
    Browse the repository at this point in the history

Commits on Jun 23, 2023

  1. Merge fixes

    @CollinAlpert
    CollinAlpert committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    cf80f04 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into issue_33799

    @CollinAlpert
    CollinAlpert committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    15b3fc2 View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2023

  1. PR fixes.

    @CollinAlpert
    CollinAlpert committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    d0fe078 View commit details
    Browse the repository at this point in the history

  2. Merge conflicts

    @buyaa-n
    buyaa-n committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    0db38df View commit details
    Browse the repository at this point in the history

  3. Revert unrelated change

    @buyaa-n
    buyaa-n committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    4f47479 View commit details
    Browse the repository at this point in the history