Skip to content

Commit

Permalink
Remove unnecessary WpfFact usage
Browse files Browse the repository at this point in the history
  • Loading branch information
tmat committed Jan 6, 2024
1 parent 718c0fa commit 116d5d3
Show file tree
Hide file tree
Showing 27 changed files with 11,049 additions and 11,169 deletions.
21,310 changes: 10,595 additions & 10,715 deletions src/Analyzers/CSharp/Tests/RemoveUnnecessaryCast/RemoveUnnecessaryCastTests.cs

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
Expand Up @@ -2155,7 +2155,7 @@ End Class
End Function

<WorkItem("http://vstfdevdiv:8080/DevDiv2/DevDiv/_workitems/edit/770187")>
<WpfFact(Skip:="770187")>
<Fact(Skip:="770187")>
Public Async Function TestDoNotRemoveNecessaryCastInSelectCaseExpression() As Task
' Cast removal invokes a different user defined operator, hence the cast is necessary.

Expand Down Expand Up @@ -2200,7 +2200,7 @@ End Namespace]]>
End Function

<WorkItem("http://vstfdevdiv:8080/DevDiv2/DevDiv/_workitems/edit/770187")>
<WpfFact(Skip:="770187")>
<Fact(Skip:="770187")>
Public Async Function TestDoNotRemoveNecessaryCastInSelectCaseExpression2() As Task
' Cast removal invokes a different user defined operator, hence the cast is necessary.

Expand Down Expand Up @@ -2245,7 +2245,7 @@ End Namespace]]>
End Function

<WorkItem("http://vstfdevdiv:8080/DevDiv2/DevDiv/_workitems/edit/770187")>
<WpfFact(Skip:="770187")>
<Fact(Skip:="770187")>
Public Async Function TestDoNotRemoveNecessaryCastInSelectCaseExpression3() As Task
' Cast removal invokes a different user defined operator, hence the cast is necessary.

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ public TestCodeAction(Solution changedSolution)
}
}

[WpfFact, WorkItem("https://devdiv.visualstudio.com/DevDiv/_queries/edit/1419139")]
[Fact, WorkItem("https://devdiv.visualstudio.com/DevDiv/_queries/edit/1419139")]
public async Task TestMakeTextChangeWithInterveningEditToDifferentFile()
{
// This should succeed as the code action is trying to edit a file that is not touched by the actual
Expand Down Expand Up @@ -86,7 +86,7 @@ class Program2
});
}

[WpfFact, WorkItem("https://devdiv.visualstudio.com/DevDiv/_queries/edit/1419139")]
[Fact, WorkItem("https://devdiv.visualstudio.com/DevDiv/_queries/edit/1419139")]
public async Task TestMakeTextChangeWithInterveningRemovalToDifferentFile()
{
// This should succeed as the code action is trying to edit a file that is not touched by the actual
Expand Down Expand Up @@ -118,7 +118,7 @@ class Program2
});
}

[WpfFact, WorkItem("https://devdiv.visualstudio.com/DevDiv/_queries/edit/1419139")]
[Fact, WorkItem("https://devdiv.visualstudio.com/DevDiv/_queries/edit/1419139")]
public async Task TestMakeTextChangeWithInterveningEditToSameFile()
{
// This should fail as the code action is trying to edit a file that is was already edited by the actual
Expand Down Expand Up @@ -150,7 +150,7 @@ class Program2
});
}

[WpfFact, WorkItem("https://devdiv.visualstudio.com/DevDiv/_queries/edit/1419139")]
[Fact, WorkItem("https://devdiv.visualstudio.com/DevDiv/_queries/edit/1419139")]
public async Task TestMakeTextChangeWithInterveningRemovalOfThatFile()
{
// This should fail as the code action is trying to edit a file that is subsequently removed.
Expand Down Expand Up @@ -181,7 +181,7 @@ class Program2
});
}

[WpfFact, WorkItem("https://devdiv.visualstudio.com/DevDiv/_queries/edit/1419139")]
[Fact, WorkItem("https://devdiv.visualstudio.com/DevDiv/_queries/edit/1419139")]
public async Task TestMakeProjectChangeWithInterveningTextEdit()
{
// This should fail as we don't want to make non-text changes that may have undesirable results to the solution
Expand Down
8 changes: 4 additions & 4 deletions src/Features/CSharpTest/GenerateMethod/GenerateMethodTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -1108,7 +1108,7 @@ private void Goo(int? v)
""");
}

[WpfFact]
[Fact]
public async Task TestPointArgument()
{
await TestInRegularAndScriptAsync(
Expand Down Expand Up @@ -1141,7 +1141,7 @@ private unsafe void Goo(int* p)
""");
}

[WpfFact]
[Fact]
public async Task TestArgumentWithPointerName()
{
await TestInRegularAndScriptAsync(
Expand Down Expand Up @@ -1174,7 +1174,7 @@ private unsafe void Goo(int* p)
""");
}

[WpfFact]
[Fact]
public async Task TestArgumentWithPointTo()
{
await TestInRegularAndScriptAsync(
Expand Down Expand Up @@ -1207,7 +1207,7 @@ private void Goo(int v)
""");
}

[WpfFact]
[Fact]
public async Task TestArgumentWithAddress()
{
await TestInRegularAndScriptAsync(
Expand Down
28 changes: 14 additions & 14 deletions src/Features/CSharpTest/GenerateType/GenerateTypeTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -473,7 +473,7 @@ private class Goo
index: 2);
}

[WpfFact]
[Fact]
public async Task TestGenerateClassFromFieldDeclarationIntoGlobalNamespace()
{
await TestAddDocumentInRegularAndScriptAsync(
Expand All @@ -485,7 +485,7 @@ await TestAddDocumentInRegularAndScriptAsync(
expectedDocumentName: "Goo.cs");
}

[WpfFact]
[Fact]
public async Task TestGenerateClassFromFieldDeclarationIntoCustomNamespace()
{
await TestAddDocumentInRegularAndScriptAsync(
Expand Down Expand Up @@ -1177,7 +1177,7 @@ internal class C
}

[WorkItem("http://vstfdevdiv:8080/DevDiv2/DevDiv/_workitems/edit/538516")]
[WpfFact]
[Fact]
public async Task TestGenerateClassFromIntoNewNamespace()
{
await TestAddDocumentInRegularAndScriptAsync(
Expand Down Expand Up @@ -3357,7 +3357,7 @@ internal class @int
}

[WorkItem("http://vstfdevdiv:8080/DevDiv2/DevDiv/_workitems/edit/539535")]
[WpfFact]
[Fact]
public async Task TestGenerateIntoNewFile()
{
await TestAddDocumentInRegularAndScriptAsync(
Expand All @@ -3375,7 +3375,7 @@ public Bar()
expectedDocumentName: "Bar.cs");
}

[WpfFact]
[Fact]
public async Task TestGenerateIntoNewFileWithUsings1()
{
await TestAddDocumentInRegularAndScriptAsync(
Expand All @@ -3398,7 +3398,7 @@ public Bar(List<int> list)
expectedDocumentName: "Bar.cs");
}

[WpfFact]
[Fact]
public async Task TestGenerateIntoNewFileWithUsings2()
{
await TestAddDocumentInRegularAndScriptAsync(
Expand Down Expand Up @@ -4685,7 +4685,7 @@ await TestSmartTagTextAsync(
}

[WorkItem("http://vstfdevdiv:8080/DevDiv2/DevDiv/_workitems/edit/543853")]
[WpfFact]
[Fact]
public async Task TestAddDocumentForGlobalNamespace()
{
await TestAddDocumentInRegularAndScriptAsync(
Expand Down Expand Up @@ -4858,7 +4858,7 @@ public class C
}

[WorkItem("http://vstfdevdiv:8080/DevDiv2/DevDiv/_workitems/edit/932602")]
[WpfFact]
[Fact]
public async Task TestGenerateTypeInFolderNotDefaultNamespace_0()
{
var code = @"<Workspace>
Expand Down Expand Up @@ -4887,7 +4887,7 @@ await TestAddDocumentInRegularAndScriptAsync(code,
expectedDocumentName: "ClassB.cs");
}

[WpfFact]
[Fact]
public async Task TestGenerateTypeInFolderNotDefaultNamespace_0_FileScopedNamespace()
{
var code = @"<Workspace>
Expand Down Expand Up @@ -4918,7 +4918,7 @@ await TestAddDocumentInRegularAndScriptAsync(code,
}

[WorkItem("http://vstfdevdiv:8080/DevDiv2/DevDiv/_workitems/edit/932602")]
[WpfFact]
[Fact]
public async Task TestGenerateTypeInFolderNotDefaultNamespace_1()
{
var code = @"<Workspace>
Expand Down Expand Up @@ -5309,7 +5309,7 @@ public B()
}

[WorkItem("https://github.com/dotnet/roslyn/issues/17361")]
[WpfFact]
[Fact]
public async Task TestPreserveFileBanner1()
{
await TestAddDocumentInRegularAndScriptAsync(
Expand All @@ -5332,7 +5332,7 @@ internal class Goo
}

[WorkItem("https://github.com/dotnet/roslyn/issues/17361")]
[WpfFact]
[Fact]
public async Task TestPreserveFileBanner2()
{
await TestAddDocumentInRegularAndScriptAsync(
Expand All @@ -5352,7 +5352,7 @@ void Main ( )
}

[WorkItem("https://github.com/dotnet/roslyn/issues/17361")]
[WpfFact]
[Fact]
public async Task TestPreserveFileBanner3()
{
await TestAddDocumentInRegularAndScriptAsync(
Expand Down Expand Up @@ -5383,7 +5383,7 @@ public Goo(StackOverflowException e)
}

[WorkItem("https://github.com/dotnet/roslyn/issues/17361")]
[WpfFact]
[Fact]
public async Task TestPreserveFileBanner4()
{
await TestAddDocumentInRegularAndScriptAsync(
Expand Down
Loading

0 comments on commit 116d5d3

Please sign in to comment.