From 17b9b60feedba435e039b2fbee643a6062714ca7 Mon Sep 17 00:00:00 2001 From: Julien Couvreur Date: Mon, 29 Mar 2021 16:52:37 -0700 Subject: [PATCH] Update parameter names in record-struct tests --- .../Test/Semantic/Semantics/RecordStructTests.cs | 14 +++++++------- .../CSharp/Test/Semantic/Semantics/RecordTests.cs | 4 ++-- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/src/Compilers/CSharp/Test/Semantic/Semantics/RecordStructTests.cs b/src/Compilers/CSharp/Test/Semantic/Semantics/RecordStructTests.cs index a2fc2b2d6ba05..7b77466ee8cab 100644 --- a/src/Compilers/CSharp/Test/Semantic/Semantics/RecordStructTests.cs +++ b/src/Compilers/CSharp/Test/Semantic/Semantics/RecordStructTests.cs @@ -759,8 +759,8 @@ int I.M(string s) "System.Int32 S.M(System.String s)", "System.String S.ToString()", "System.Boolean S.PrintMembers(System.Text.StringBuilder builder)", - "System.Boolean S.op_Inequality(S r1, S r2)", - "System.Boolean S.op_Equality(S r1, S r2)", + "System.Boolean S.op_Inequality(S left, S right)", + "System.Boolean S.op_Equality(S left, S right)", "System.Int32 S.GetHashCode()", "System.Boolean S.Equals(System.Object obj)", "System.Boolean S.Equals(S other)", @@ -1764,8 +1764,8 @@ public void set_X() { } "System.Int32 C.set_Y(System.Int32 value)", "System.String C.ToString()", "System.Boolean C.PrintMembers(System.Text.StringBuilder builder)", - "System.Boolean C.op_Inequality(C r1, C r2)", - "System.Boolean C.op_Equality(C r1, C r2)", + "System.Boolean C.op_Inequality(C left, C right)", + "System.Boolean C.op_Equality(C left, C right)", "System.Int32 C.GetHashCode()", "System.Boolean C.Equals(System.Object obj)", "System.Boolean C.Equals(C other)", @@ -4263,7 +4263,7 @@ True True False False var comp = (CSharpCompilation)verifier.Compilation; MethodSymbol op = comp.GetMembers("A." + WellKnownMemberNames.EqualityOperatorName).OfType().Single(); - Assert.Equal("System.Boolean A.op_Equality(A r1, A r2)", op.ToTestDisplayString()); + Assert.Equal("System.Boolean A.op_Equality(A left, A right)", op.ToTestDisplayString()); Assert.Equal(Accessibility.Public, op.DeclaredAccessibility); Assert.True(op.IsStatic); Assert.False(op.IsAbstract); @@ -4273,7 +4273,7 @@ True True False False Assert.True(op.IsImplicitlyDeclared); op = comp.GetMembers("A." + WellKnownMemberNames.InequalityOperatorName).OfType().Single(); - Assert.Equal("System.Boolean A.op_Inequality(A r1, A r2)", op.ToTestDisplayString()); + Assert.Equal("System.Boolean A.op_Inequality(A left, A right)", op.ToTestDisplayString()); Assert.Equal(Accessibility.Public, op.DeclaredAccessibility); Assert.True(op.IsStatic); Assert.False(op.IsAbstract); @@ -4459,7 +4459,7 @@ public record struct RecordB(); "; var comp = CreateCompilation(src); var b = comp.GlobalNamespace.GetTypeMember("RecordB"); - AssertEx.SetEqual(new[] { "System.Boolean RecordB.op_Equality(RecordB r1, RecordB r2)" }, + AssertEx.SetEqual(new[] { "System.Boolean RecordB.op_Equality(RecordB left, RecordB right)" }, b.GetSimpleNonTypeMembers("op_Equality").ToTestDisplayStrings()); } diff --git a/src/Compilers/CSharp/Test/Semantic/Semantics/RecordTests.cs b/src/Compilers/CSharp/Test/Semantic/Semantics/RecordTests.cs index 7df3b58d7a53c..d7562ba36955e 100644 --- a/src/Compilers/CSharp/Test/Semantic/Semantics/RecordTests.cs +++ b/src/Compilers/CSharp/Test/Semantic/Semantics/RecordTests.cs @@ -1684,8 +1684,8 @@ .maxstack 1 "System.Type C.EqualityContract { get; }", "System.String C.ToString()", "System.Boolean C." + WellKnownMemberNames.PrintMembersMethodName + "(System.Text.StringBuilder builder)", - "System.Boolean C.op_Inequality(C? r1, C? r2)", - "System.Boolean C.op_Equality(C? r1, C? r2)", + "System.Boolean C.op_Inequality(C? left, C? right)", + "System.Boolean C.op_Equality(C? left, C? right)", "System.Int32 C.GetHashCode()", "System.Boolean C.Equals(System.Object? obj)", "System.Boolean C.Equals(C? other)",