From b9e9a3e16f29b04819efe6897666b426578a005a Mon Sep 17 00:00:00 2001 From: Manish Vasani Date: Thu, 16 Apr 2020 16:10:29 -0700 Subject: [PATCH] Remove public API on DocumentOptionSet https://github.com/dotnet/roslyn/pull/42931 added this API as we thought converting the base `OptionSet` type's abstract method to non-abstract and removing the override on `DocumentOptionSet` would be a binary breaking change for callers. However, based on the public API review meeting, it was identified that it would indeed not be a breaking change as the compiler would have emitted a callvirt to `OptionSet.GetOption`. --- src/Workspaces/Core/Portable/Options/DocumentOptionSet.cs | 3 --- src/Workspaces/Core/Portable/PublicAPI.Unshipped.txt | 1 - 2 files changed, 4 deletions(-) diff --git a/src/Workspaces/Core/Portable/Options/DocumentOptionSet.cs b/src/Workspaces/Core/Portable/Options/DocumentOptionSet.cs index 0d39377dc47d1..f11ff5b281517 100644 --- a/src/Workspaces/Core/Portable/Options/DocumentOptionSet.cs +++ b/src/Workspaces/Core/Portable/Options/DocumentOptionSet.cs @@ -29,9 +29,6 @@ internal DocumentOptionSet(OptionSet backingOptionSet, string language) private protected override object? GetOptionCore(OptionKey optionKey) => _backingOptionSet.GetOption(optionKey); - public new object? GetOption(OptionKey optionKey) - => base.GetOption(optionKey); - public T GetOption(PerLanguageOption option) => _backingOptionSet.GetOption(option, _language); diff --git a/src/Workspaces/Core/Portable/PublicAPI.Unshipped.txt b/src/Workspaces/Core/Portable/PublicAPI.Unshipped.txt index 6a74d6a522bed..bd8e4484e6ab6 100644 --- a/src/Workspaces/Core/Portable/PublicAPI.Unshipped.txt +++ b/src/Workspaces/Core/Portable/PublicAPI.Unshipped.txt @@ -3,7 +3,6 @@ Microsoft.CodeAnalysis.Editing.DeclarationModifiers.IsVolatile.get -> bool Microsoft.CodeAnalysis.Editing.DeclarationModifiers.WithIsExtern(bool isExtern) -> Microsoft.CodeAnalysis.Editing.DeclarationModifiers Microsoft.CodeAnalysis.Editing.DeclarationModifiers.WithIsVolatile(bool isVolatile) -> Microsoft.CodeAnalysis.Editing.DeclarationModifiers Microsoft.CodeAnalysis.Editing.SyntaxGenerator.ElementBindingExpression(params Microsoft.CodeAnalysis.SyntaxNode[] arguments) -> Microsoft.CodeAnalysis.SyntaxNode -Microsoft.CodeAnalysis.Options.DocumentOptionSet.GetOption(Microsoft.CodeAnalysis.Options.OptionKey optionKey) -> object *REMOVED*override Microsoft.CodeAnalysis.Options.DocumentOptionSet.GetOption(Microsoft.CodeAnalysis.Options.OptionKey optionKey) -> object Microsoft.CodeAnalysis.Options.OptionSet.GetOption(Microsoft.CodeAnalysis.Options.OptionKey optionKey) -> object *REMOVED*abstract Microsoft.CodeAnalysis.Options.OptionSet.GetOption(Microsoft.CodeAnalysis.Options.OptionKey optionKey) -> object