Microsoft.VisualStudio.SDK (#72359)

dotnet · Mar 13, 2024 · a093664 · a093664
1 parent 72396c0
commit a093664
Show file tree

Hide file tree

Showing 2 changed files with 41 additions and 26 deletions.
diff --git a/eng/Directory.Packages.props b/eng/Directory.Packages.props
@@ -21,7 +21,7 @@
     <MicrosoftWindowsDesktopAppRuntimePackagesVersion>8.0.0</MicrosoftWindowsDesktopAppRuntimePackagesVersion>
     <xunitVersion>2.4.1</xunitVersion>
     <SqliteVersion>2.1.0</SqliteVersion>
-    <MicrosoftVisualStudioExtensibilityVersion>17.9.43-preview-1</MicrosoftVisualStudioExtensibilityVersion>
+    <MicrosoftVisualStudioExtensibilityVersion>17.10.22-preview-1</MicrosoftVisualStudioExtensibilityVersion>
   </PropertyGroup>
 
   <!--
@@ -54,7 +54,7 @@
     <!--
       Visual Studio
     -->
-    <PackageVersion Include="Microsoft.VisualStudio.SDK" Version="17.9.35796-preview.1" />
+    <PackageVersion Include="Microsoft.VisualStudio.SDK" Version="17.10.234-preview.1" />
     <PackageVersion Include="Microsoft.Internal.VisualStudio.Shell.Framework" Version="17.9.35796-preview.1" />
     <PackageVersion Include="Microsoft.ServiceHub.Client" Version="4.2.1017" />
     <PackageVersion Include="Microsoft.VisualStudio.Extensibility" Version="$(MicrosoftVisualStudioExtensibilityVersion)" />
@@ -88,34 +88,32 @@
     <!--
       Subset of Microsoft.VisualStudio.Sdk meta-package (run `csi generate-vssdk-versions.csx` to update based on VSSDK meta-package).
     -->
-    <PackageVersion Include="Microsoft.VisualStudio.Composition" Version="17.10.11-preview" />
-    <PackageVersion Include="Microsoft.VisualStudio.CoreUtility" Version="17.9.80-preview" />
-    <PackageVersion Include="Microsoft.VisualStudio.Editor" Version="17.9.80-preview" />
-    <PackageVersion Include="Microsoft.VisualStudio.ImageCatalog" Version="17.10.639-preview.1" />
-    <PackageVersion Include="Microsoft.VisualStudio.Imaging.Interop.14.0.DesignTime" Version="17.10.616-preview.1" />
-    <PackageVersion Include="Microsoft.VisualStudio.Language.NavigateTo.Interfaces" Version="17.9.80-preview" />
-    <PackageVersion Include="Microsoft.VisualStudio.LanguageServer.Client" Version="17.9.25-preview" />
-    <PackageVersion Include="Microsoft.VisualStudio.Language.StandardClassification" Version="17.9.80-preview" />
-    <PackageVersion Include="Microsoft.VisualStudio.Language" Version="17.9.80-preview" />
+    <PackageVersion Include="Microsoft.ServiceHub.Framework" Version="4.4.22" />
+    <PackageVersion Include="Microsoft.VisualStudio.Composition" Version="17.10.8-preview" />
+    <PackageVersion Include="Microsoft.VisualStudio.Composition.Analyzers" Version="17.10.8-preview" />
+    <PackageVersion Include="Microsoft.VisualStudio.CoreUtility" Version="17.10.13-preview" />
+    <PackageVersion Include="Microsoft.VisualStudio.Editor" Version="17.10.13-preview" />
+    <PackageVersion Include="Microsoft.VisualStudio.ImageCatalog" Version="17.10.234-preview.1" />
+    <PackageVersion Include="Microsoft.VisualStudio.Imaging.Interop.14.0.DesignTime" Version="17.10.157-preview.1" />
+    <PackageVersion Include="Microsoft.VisualStudio.Language" Version="17.10.13-preview" />
+    <PackageVersion Include="Microsoft.VisualStudio.Language.NavigateTo.Interfaces" Version="17.10.13-preview" />
+    <PackageVersion Include="Microsoft.VisualStudio.Language.StandardClassification" Version="17.10.13-preview" />
+    <PackageVersion Include="Microsoft.VisualStudio.LanguageServer.Client" Version="17.10.11-preview" />
     <PackageVersion Include="Microsoft.VisualStudio.RemoteControl" Version="16.3.52" />
     <PackageVersion Include="Microsoft.VisualStudio.RpcContracts" Version="17.10.3-preview" />
-    <PackageVersion Include="Microsoft.VisualStudio.Shell.15.0" Version="17.10.639-preview.1" />
-    <PackageVersion Include="Microsoft.VisualStudio.Telemetry" Version="17.10.4" />
-    <PackageVersion Include="Microsoft.VisualStudio.Text.Data" Version="17.9.80-preview" />
-    <PackageVersion Include="Microsoft.VisualStudio.Text.Logic" Version="17.9.80-preview" />
-    <PackageVersion Include="Microsoft.VisualStudio.Text.UI" Version="17.9.80-preview" />
-    <PackageVersion Include="Microsoft.VisualStudio.Text.UI.Wpf" Version="17.9.80-preview" />
+    <PackageVersion Include="Microsoft.VisualStudio.Shell.15.0" Version="17.10.234-preview.1" />
+    <PackageVersion Include="Microsoft.VisualStudio.Telemetry" Version="17.9.102" />
+    <PackageVersion Include="Microsoft.VisualStudio.Text.Data" Version="17.10.13-preview" />
+    <PackageVersion Include="Microsoft.VisualStudio.Text.Logic" Version="17.10.13-preview" />
+    <PackageVersion Include="Microsoft.VisualStudio.Text.UI" Version="17.10.13-preview" />
+    <PackageVersion Include="Microsoft.VisualStudio.Text.UI.Wpf" Version="17.10.13-preview" />
     <PackageVersion Include="Microsoft.VisualStudio.Threading" Version="17.10.12-preview" />
+    <PackageVersion Include="Microsoft.VisualStudio.Threading.Analyzers" Version="17.10.12-preview" />
     <PackageVersion Include="Microsoft.VisualStudio.Utilities.Internal" Version="16.3.56" />
     <PackageVersion Include="Nerdbank.Streams" Version="2.10.69" />
     <PackageVersion Include="Newtonsoft.Json" Version="$(NewtonsoftJsonVersion)" />
     <PackageVersion Include="StreamJsonRpc" Version="2.18.6-preview" />
 
-    <!-- TODO: workaround for https://github.com/dotnet/roslyn/issues/71377 -->
-    <PackageVersion Include="Microsoft.VisualStudio.Threading.Analyzers" Version="17.10.12-preview" />
-    <PackageVersion Include="Microsoft.VisualStudio.Composition.Analyzers" Version="17.10.11-preview" />
-    <PackageVersion Include="Microsoft.ServiceHub.Framework" Version="4.4.22"/>
-
     <!--
       VS Debugger
     -->

diff --git a/eng/generate-vssdk-versions.csx b/eng/generate-vssdk-versions.csx
@@ -30,7 +30,7 @@ if (!File.Exists(vssdkPackageSpecPath))
 
 var vssdkPackageSpec = XDocument.Parse(File.ReadAllText(vssdkPackageSpecPath));
 
-var properties = new List<string>();
+var properties = new List<(string packageId, string version)>();
 
 foreach (var node in vssdkPackageSpec.Descendants())
 {
@@ -44,6 +44,7 @@ foreach (var node in vssdkPackageSpec.Descendants())
 
         if (!id.StartsWith("Microsoft.VisualStudio") &&
             !id.StartsWith("Microsoft.ServiceHub") &&
+            !id.StartsWith("Microsoft.Build") &&
             id != "Newtonsoft.Json" &&
             id != "StreamJsonRpc" &&
             id != "Nerdbank.Streams")
@@ -56,15 +57,31 @@ foreach (var node in vssdkPackageSpec.Descendants())
             continue;
         }
 
-        properties.Add($"<PackageVersion Include=\"{id}\" Version=\"{version}\" />");
+        properties.Add((id, version));
     }
 }
 
 properties.Sort();
 
-foreach (var property in properties)
+var seenMsbuild = false;
+foreach (var (id, version) in properties)
 {
-    Console.WriteLine(property);
+    if (!id.StartsWith("Microsoft.Build"))
+    {
+        Console.WriteLine($"<PackageVersion Include=\"{id}\" Version=\"{version}\" />");
+    }
+    else if (!seenMsbuild)
+    {
+        Console.WriteLine($$"""
+            <ItemGroup Condition="'$(DotnetBuildFromSource)' != 'true' and '$(TargetFramework)' == 'net472'">
+              <PackageVersion Include="Microsoft.Build" Version="{{version}}" />
+              <PackageVersion Include="Microsoft.Build.Framework" Version="{{version}}" />
+              <PackageVersion Include="Microsoft.Build.Tasks.Core" Version="{{version}}" />
+            </ItemGroup>
+            """);
+
+        seenMsbuild = true;
+    }
 }
 
 return 0;