From d886a6084a3bdf20e2262e906ae122a6b230c31a Mon Sep 17 00:00:00 2001
From: Visual Studio Languages Snap Account <vslsnap@users.noreply.github.com>
Date: Mon, 4 Jul 2016 11:50:25 -0700
Subject: [PATCH] Merge microupdate into master (#12337)

* Merge pull request #12041 from heejaechang/buildsyncrace

found one more case where documentId can be null

* prevent VS from crashing if VS got shutdown while build error reporting is in progress.

* Update our NuGet package version to 1.3.2

* Update Microsoft.DiaSymReader.Native to 1.4.0 RTM (#12141)

* Enable building of release nuget packages.

This commit makes it so that we will always try to generate release nugets except if they depend on prerelease packages. If one of our nuget packages happens to depend on prerelease packages, then when building release nugets, we will simply print a message in the build output and skip release nuget generation for that package (and allow the overall build to succeed).

* Address code review feedback.

* Simplify script to use nuget.exe for prerelease dependency validation instead of adding custom logic in the script for this.

* Remove Microsoft.CodeAnalysis.EditorFeatures from list of prerelease nuget packages.

* Change the name of the error log file to skipped_packages.txt.

* fixed DifferenceViewer leak

this leak was responsible for about 14% of managed memory in customer's dump.

basically, in certain condition, if cancellation exception is thrown, we will not close difference viewer which cause
all text views to leak. that cause all taggers and text buffers to leak and that cause our preview workspaces to alive.
which in turn cause all solutions to alive and so on. all those objects (view, buffer, workspace, solution) are quite
big graphs. so ends up eat up 14% of memory.

added assert to make sure if we leak viewers again, we get some kind of notification.

* Skipping the InteractiveWindow Clipboard UnitTests as they cannot run on VS2015.2