Make method

dotnet · May 8, 2024 · e035fc7 · e035fc7
1 parent da8d776
commit e035fc7
Showing 1 changed file with 9 additions and 5 deletions.
diff --git a/src/Workspaces/Core/Portable/Serialization/SerializerService_Reference.cs b/src/Workspaces/Core/Portable/Serialization/SerializerService_Reference.cs
@@ -5,6 +5,7 @@
 using System;
 using System.Collections.Generic;
 using System.Collections.Immutable;
+using System.Diagnostics.CodeAnalysis;
 using System.IO;
 using System.Reflection.Metadata;
 using System.Threading;
@@ -37,6 +38,12 @@ private static bool TryGetAnalyzerImageReferenceGuid(AnalyzerImageReference imag
             return s_analyzerImageReferenceMap.TryGetValue(imageReference, out guid);
     }
 
+    private static bool TryGetAnalyzerImageReferenceFromGuid(Guid guid, [NotNullWhen(true)] out AnalyzerImageReference? imageReference)
+    {
+        lock (s_analyzerImageReferenceMapGate)
+            return s_analyzerImageReferenceMap.TryGetKey(guid, out imageReference);
+    }
+
     public static Checksum CreateChecksum(MetadataReference reference, CancellationToken cancellationToken)
     {
         if (reference is PortableExecutableReference portable)
@@ -145,11 +152,8 @@ public virtual AnalyzerReference ReadAnalyzerReferenceFrom(ObjectReader reader,
 
             case nameof(AnalyzerImageReference):
                 var guid = reader.ReadGuid();
-                lock (s_analyzerImageReferenceMapGate)
-                {
-                    Contract.ThrowIfFalse(s_analyzerImageReferenceMap.TryGetKey(guid, out var analyzerImageReference));
-                    return analyzerImageReference;
-                }
+                Contract.ThrowIfFalse(TryGetAnalyzerImageReferenceFromGuid(guid, out var analyzerImageReference));
+                return analyzerImageReference;
         }
 
         throw ExceptionUtilities.UnexpectedValue(type);