Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider adding slow span binary to tests and test agains that #22213

Closed
VSadov opened this issue Sep 20, 2017 · 1 comment
Closed

Consider adding slow span binary to tests and test agains that #22213

VSadov opened this issue Sep 20, 2017 · 1 comment
Labels
Area-Compilers Bug Language-C# New Language Feature - Readonly References Readonly References
Milestone
15.6

Comments

@VSadov
Copy link
Member

VSadov commented Sep 20, 2017

We can switch all tests to the actual span or only some subset.

For the most part we only care about APIs exposed, so we do not strictly need to test with actual span.
@VSadov VSadov added this to the 15.later milestone Sep 20, 2017
@VSadov VSadov mentioned this issue Sep 20, 2017
Merged
@VSadov
Copy link
Member Author

VSadov commented Jan 5, 2018

This does not seem to be enabling any new test scenarios, but can cause issues on runtimes where Span is in cor library.
It longer feels like a good idea.

@VSadov VSadov closed this as completed Jan 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Compilers Bug Language-C# New Language Feature - Readonly References Readonly References
Projects
None yet
Milestone
15.6
Development

No branches or pull requests
1 participant
@VSadov