Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Finalize design and implementation of IOperation and CFG for async-streams feature #30362

Closed
jcouv opened this issue Oct 7, 2018 · 0 comments · Fixed by #37963
Closed

Finalize design and implementation of IOperation and CFG for async-streams feature #30362

jcouv opened this issue Oct 7, 2018 · 0 comments · Fixed by #37963
Assignees
@jcouv
Labels
4 - In Review A fix for the issue is submitted for review. Area-Compilers Bug New Feature - Async Streams Async Streams Urgency-Soon
Milestone
16.4

Comments

@jcouv
Copy link
Member

jcouv commented Oct 7, 2018 •
edited
Loading

See tests linking to this issue. The current behavior:

  • doesn't reveal that a using or foreach as `await
  • doesn't show that MoveNextAsync() or DisposeAsync() are awaited
  • references IDisposable instead of IAsyncDisposable
@jcouv jcouv added this to the 16.0 milestone Oct 7, 2018
This was referenced Oct 7, 2018
Closed
Merged
@jaredpar jaredpar added the Bug label Oct 8, 2018
@jcouv jcouv mentioned this issue Jan 9, 2019
Merged
@jcouv jcouv modified the milestones: 16.0, 16.1, 16.2 Apr 18, 2019
@jcouv jcouv modified the milestones: 16.2, 16.3 Jun 19, 2019
@jcouv jcouv modified the milestones: 16.3, Compiler.Next Jul 24, 2019
@jcouv jcouv modified the milestones: Compiler.Next, 16.4 Aug 13, 2019
@jcouv jcouv mentioned this issue Aug 13, 2019
Merged
@jcouv jcouv added the 4 - In Review A fix for the issue is submitted for review. label Aug 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jcouv jcouv

Labels
4 - In Review A fix for the issue is submitted for review. Area-Compilers Bug New Feature - Async Streams Async Streams Urgency-Soon
Projects
None yet
Milestone
16.4
Development

Successfully merging a pull request may close this issue.

Fix IOperation for asynchronous using and foreach statements jcouv/roslyn
2 participants
@jaredpar @jcouv