Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Async-streams: Add support for enumerator-returning async-iterator method #31057

Closed
jcouv opened this issue Nov 9, 2018 · 0 comments
Closed

Comments

@jcouv
Copy link
Member

jcouv commented Nov 9, 2018

async System.Collections.Generic.IAsyncEnumerator<string> M() { ... }

Some notes to self:

  • Will probably need to override InitializeStateMachine for async-iterator state machines. See the comment in that method for iterator state machines:
            // var stateMachineLocal = new IteratorImplementationClass(N)
            // where N is either 0 (if we're producing an enumerator) or -2 (if we're producing an enumerable)
  • The kickoff method probably needs some other changes too

  • Will probably need to modify PreserveInitialParameterValues (true for IAsyncEnumerable, but false for IAsyncEnumerator or regular async methods)

  • Some methods can be removed (GetAsyncEnumerator, DisposeAsync)

  • Some interfaces can be removed (IAsyncEnumerable, IAsyncDisposable)

@jcouv jcouv added the New Feature - Async Streams Async Streams label Nov 9, 2018
@jcouv jcouv added this to the 16.0.P2 milestone Nov 9, 2018
@jcouv jcouv self-assigned this Nov 9, 2018
@jcouv jcouv changed the title Add support for enumerator-returning async-iterator method Async-streams: Add support for enumerator-returning async-iterator method Nov 9, 2018
@jaredpar jaredpar added the Bug label Nov 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants