Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorconfig naming convention for tuple element names #38705

Open
jnm2 opened this issue Sep 16, 2019 · 5 comments
Open

Editorconfig naming convention for tuple element names #38705

jnm2 opened this issue Sep 16, 2019 · 5 comments
Labels
Area-IDE Concept-Continuous Improvement help wanted The issue is "up for grabs" - add a comment if you are interested in working on it
Milestone

Comments

@jnm2
Copy link
Contributor

jnm2 commented Sep 16, 2019

Now that we have settled on the guidance of pascal case for tuple element names (dotnet/corefx#35595, https://github.com/dotnet/corefx/issues/33553), it would be nice to have a tuple_element symbol kind to which a naming convention can be applied.

https://docs.microsoft.com/en-us/visualstudio/ide/editorconfig-naming-conventions?view=vs-2019#kinds-of-symbols

@kofifus
Copy link

kofifus commented Sep 19, 2019

As far as I know there is no official decision on this. The [docs](https://docs.microsoft.com/en-us/dotnet/csharp/tuples use camelCase. see DotNetAnalyzers/StyleCopAnalyzers#3019

@jnm2
Copy link
Contributor Author

jnm2 commented Sep 19, 2019

@kofifus The official decision is referenced in dotnet/corefx#35595 and confirmed at https://github.com/dotnet/corefx/issues/33553#issuecomment-531420515 which mentions that they are working on docs.

@kofifus
Copy link

kofifus commented Sep 19, 2019

thanks @jnm2 maybe it's just how I read it but nothing in those discussion seems very official ..

@jnm2
Copy link
Contributor Author

jnm2 commented Sep 19, 2019

It's as official as any decision that has been made between the C# language design team and the framework design team. You'll have to be patient about the docs. (For example, the docs still have pre-.NET 4.0 advice about how to implement IDisposable, when SafeHandle is the only thing you should be using for unmanaged resources.)

@sharwell
Copy link
Member

sharwell commented Sep 19, 2019

Note that this naming style is unrelated to the design guideline. From the perspective of Roslyn's naming style feature, PascalCase and camelCase are equally valid options for this, with neither having priority. We definitely want to support the user specifying their preferred style for these elements. 👍

@sharwell sharwell added help wanted The issue is "up for grabs" - add a comment if you are interested in working on it Concept-Continuous Improvement labels Sep 19, 2019
@jinujoseph jinujoseph added this to the Backlog milestone Oct 1, 2019
@github-project-automation github-project-automation bot moved this to InQueue in Small Fixes Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-IDE Concept-Continuous Improvement help wanted The issue is "up for grabs" - add a comment if you are interested in working on it
Projects
Status: InQueue
Development

No branches or pull requests

5 participants