Make Microsoft.Cci.RootModuleType methods virtual

[jakubmisek]

A proposal to make methods on Microsoft.Cci.RootModuleType virtual so it can be overridden. 3rd party compilers would be able to define static module constructors and other methods in there (which is in comply with MSIL specs)

Especially helpful would be to alter the method GetMethods

roslyn/src/Compilers/Core/Portable/PEWriter/RootModuleType.cs

Line 139 in e09c42a

public IEnumerable<IMethodDefinition> GetMethods(EmitContext context)

to

public virtual IEnumerable<IMethodDefinition> GetMethods(EmitContext context)

[jnm2]

I ran into this with #40500.

Would reimplementing the Cci.ITypeDefinition.GetMethods interface method be a good workaround, or are there cases where GetMethods is not called using the interface?

/cc @jcouv

[jakubmisek]

thank you! An implementation of Cci.ITypeDefinition.GetMethods providing some extension points would be sufficient.

As of now we had to re-implement the class just to make GetMethods to return a symbol for our .cctor

https://github.com/peachpiecompiler/peachpie/blob/a2b9abf1516c206c34cd8095076382bf85688d0a/src/Peachpie.CodeAnalysis/Emitter/Model/PhpRootModuleType.cs#L146

[gafter]

I understand this feature request is to enhance Roslyn's APIs to support 3rd party compilers. Supporting 3rd party compilers is not a goal of Roslyn, but I'll keep this feature request open.

[jakubmisek]

That's alright, thank you. It can be workarounded by copy-pasting the RootModuleType source.