Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make an end-to-end test for making a compilation from pdb/pe/sourcelink #44703

Closed
ryzngard opened this issue May 29, 2020 · 4 comments
Closed
Assignees
Labels
Area-Compilers Feature - Rebuild Compiler ability to verify provenance of code via rebuild operations
Milestone

Comments

@ryzngard
Copy link
Contributor

With #44373 we're adding compilation options and metadata references to portable PDBs so that a compilation can be reconstructed and be bytewise equal to a PE (with some exceptions around signing and non-deterministic builds)

This tracks us adding an integration test to verify that we can achieve this, and keep the feature in good health moving forward.

@clairernovotny
Copy link
Member

Could this test be in the form useful for a global tool to use or would we be duplicating the logic of this test to create that tool/library?

@jinujoseph jinujoseph added the Test Test failures in roslyn-CI label Jun 23, 2020
@jinujoseph jinujoseph added this to the 16.8 milestone Jun 23, 2020
@tmat
Copy link
Member

tmat commented Jun 25, 2020

We will likely be able to share the core logic.

@ryzngard ryzngard modified the milestones: 16.8, 16.9 Nov 12, 2020
@jinujoseph jinujoseph modified the milestones: 16.9, 16.10 Mar 28, 2021
@ryzngard
Copy link
Contributor Author

@jaredpar @RikkiGibson I don't think this issue is needed anymore? Wanted to double check before closing.

@RikkiGibson
Copy link
Contributor

That's right. I think the Correctness_Rebuild leg more or less represents the resolution of this issue.

@RikkiGibson RikkiGibson added Feature - Rebuild Compiler ability to verify provenance of code via rebuild operations Area-Compilers and removed Area-IDE Test Test failures in roslyn-CI labels May 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Compilers Feature - Rebuild Compiler ability to verify provenance of code via rebuild operations
Projects
None yet
Development

No branches or pull requests

6 participants