Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BindWithExpression should handle hiding/overriding Clone #44908

Closed
RikkiGibson opened this issue Jun 6, 2020 · 3 comments · Fixed by #45397
Closed

BindWithExpression should handle hiding/overriding Clone #44908

RikkiGibson opened this issue Jun 6, 2020 · 3 comments · Fixed by #45397
Labels
Area-Compilers Bug New Language Feature - Records Records

Comments

@RikkiGibson
Copy link
Contributor

RikkiGibson commented Jun 6, 2020 •
edited by jcouv
Loading

This issue is referenced in source

roslyn/src/Compilers/CSharp/Portable/Binder/Binder_WithExpression.cs

Line 53 in f089d87

// PROTOTYPE: Should handle hiding/overriding

note that other PROTOTYPE comments in the method are addressed by #44582
@jaredpar jaredpar added the Bug label Jun 22, 2020
@jcouv
Copy link
Member

jcouv commented Jun 23, 2020

Clone is no longer speakable, so cannot be hidden/overriden. Closing

@jcouv jcouv closed this as completed Jun 23, 2020
@RikkiGibson
Copy link
Contributor Author

When closing such issues could we please make sure to delete references to the issue in code?

@jcouv jcouv reopened this Jun 23, 2020
@jcouv
Copy link
Member

jcouv commented Jun 23, 2020

Thanks for catching that. Re-opening until we remove references

@RikkiGibson RikkiGibson mentioned this issue Jun 23, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Compilers Bug New Language Feature - Records Records
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update Binder_WithExpression.cs dotnet/roslyn
3 participants
@jaredpar @RikkiGibson @jcouv