Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test plan for "Mix declarations and variables in deconstruction" #47746

Closed
2 of 5 tasks
jcouv opened this issue Sep 16, 2020 · 2 comments
Closed
2 of 5 tasks

Test plan for "Mix declarations and variables in deconstruction" #47746

jcouv opened this issue Sep 16, 2020 · 2 comments
Assignees
@jcouv
Labels
Area-Compilers

Comments

@jcouv
Copy link
Member

jcouv commented Sep 16, 2020 •
edited
Loading

Championed issue: dotnet/csharplang#125
PR: #44476

Compiler:

  • LangVer
  • A data flow test would be good (a test in the vein of RegionAnalysisTests.AnalysisOfExpressionInTupleEquality).
  • Let's check the semantic model in nested scenario (see VerifyModelForDeconstructionLocal which covers declaration, and add checks for GetTypeInfo and GetSymbolInfo on variables used in mixed declarations).
  • Add an IOperation test

IDE:
@jcouv jcouv self-assigned this Sep 16, 2020
@jcouv jcouv mentioned this issue Sep 16, 2020
Merged
@jcouv
Copy link
Member Author

jcouv commented Jan 28, 2021

This was merged under LangVersion=Preview as part of VS 16.10.

@jcouv
Copy link
Member Author

jcouv commented Mar 17, 2022

Feature was merged over a year ago. Closing the test plan

@jcouv jcouv closed this as completed Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jcouv jcouv

Labels
Area-Compilers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gafter @jcouv