Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source generated documents should be opened in the real workspace instead of Miscellaneous files #50676

Closed
4 tasks
jasonmalinowski opened this issue Jan 21, 2021 · 9 comments
Assignees
Labels
Area-IDE Concept-Continuous Improvement Resolution-Not Reproducible The described behavior could not be reproduced by developers
Milestone

Comments

@jasonmalinowski
Copy link
Member

jasonmalinowski commented Jan 21, 2021

Some tasks for the implementation

@jasonmalinowski
Copy link
Member Author

The core of this is done under a feature flag, moving to 16.11 for the rest of the todo items.

@jasonmalinowski jasonmalinowski modified the milestones: 16.10, 16.11 May 10, 2021
@jinujoseph jinujoseph modified the milestones: 16.11, 17.0 Jul 16, 2021
@jasonmalinowski jasonmalinowski modified the milestones: 17.0, 17.1 Sep 13, 2021
@jasonmalinowski
Copy link
Member Author

The feature checkbox is there, we're targeting 17.1 for enabling it by default.

@jasonmalinowski jasonmalinowski modified the milestones: 17.1, 17.2 Jan 5, 2022
@jasonmalinowski jasonmalinowski modified the milestones: 17.2, 17.3 Mar 23, 2022
@jasonmalinowski
Copy link
Member Author

The checkbox is there, but we've fixed enough in 17.2 that we don't want to turn it on late. It'll be turned on by default in 17.3.

@jasonmalinowski jasonmalinowski modified the milestones: 17.3, 17.4 Jul 6, 2022
@jasonmalinowski jasonmalinowski modified the milestones: 17.4, 17.5 Sep 28, 2022
@arunchndr arunchndr modified the milestones: 17.5, 17.5 P1 Oct 3, 2022
@CyrusNajmabadi
Copy link
Member

This seems to be done:

image

Closing out.

@CyrusNajmabadi CyrusNajmabadi closed this as not planned Won't fix, can't repro, duplicate, stale Mar 7, 2023
@CyrusNajmabadi CyrusNajmabadi added the Resolution-Not Reproducible The described behavior could not be reproduced by developers label Mar 7, 2023
@Sergio0694
Copy link
Contributor

This doesn't seem to be completely fixed, I just reproed this with 17.5.3:

image

Ended up here by F11 stepping into a method that called a generated one while debugging (after hitting a breakpoint in the manually written method that invoked the generated one). VS went into this file and let me continue debugging (eg. with F10 to go line by line), but the file was still classified as "miscellaneous", and IntelliSense was half broken (eg. CTRL + click and F12 didn't work at all and wouldn't let me jump to selected symbols, such as other generated members the code is using).

@jasonmalinowski
Copy link
Member Author

@Sergio0694 Do you have this unchecked in Tools > Options?

image

We've rolled out the feature flag to all users at this point (unless I broke something), but if you had manually turned it off at some point you might not see it active.

@Sergio0694
Copy link
Contributor

Yup, I have that option set 🥲

@jasonmalinowski
Copy link
Member Author

Was this the file that the debugger opened? Can you copy/paste in the path that the file is? You can redact the filename and username, I'll be looking at exactly where under %TEMP% or similar it is.

@Sergio0694
Copy link
Contributor

The file is in:

"C:\Users<USERNAME>\AppData\Local\Temp.vsdbgsrc\8A80FD2566EE423D4F1DDB6B1DA2EBF7C81E2489"

I can confirm the repro steps are pretty easy at least, if that helps:

  • Source generate some method/property/whatever
  • Step into it with F11 from some normal code

That'll open the generated file in miscellaneous mode, from that path.

Also should we reopen this, or should I open a different issue to track this? 🙂
And thank you for looking into this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-IDE Concept-Continuous Improvement Resolution-Not Reproducible The described behavior could not be reproduced by developers
Projects
None yet
Development

No branches or pull requests

5 participants