Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow renaming reloadable types #54886

Open
tmat opened this issue Jul 16, 2021 · 0 comments
Open

Allow renaming reloadable types #54886

tmat opened this issue Jul 16, 2021 · 0 comments
Assignees
@tmat
Labels
Area-IDE Concept-Continuous Improvement Feature - Rename Interactive-EnC
Milestone
Backlog

Comments

@tmat
Copy link
Member

tmat commented Jul 16, 2021 •
edited
Loading

Currently disallowed to prevent potential name collision in the following scenario:

Gen 1: An existing reloadable type A is renamed to B: type B#1 is emitted
Gen 2: A new, non-reloadable type A is added: type A is emitted, which collides with existing type A.

A solution would be to issue a CLR rename of reloadable type A when it is renamed the first time.

A similar situation might occur when changing arity.
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Jul 16, 2021
@tmat tmat added this to the Next milestone Jul 16, 2021
This was referenced Jul 16, 2021
Open
Open
Closed
@jinujoseph jinujoseph added Concept-Continuous Improvement and removed untriaged Issues and PRs which have not yet been triaged by a lead labels Jul 20, 2021
@jinujoseph jinujoseph modified the milestones: Next, 17.0 Jul 20, 2021
@jinujoseph jinujoseph modified the milestones: 17.0, 17.1 Sep 27, 2021
@tmat tmat modified the milestones: 17.1, Backlog Jan 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tmat tmat

Labels
Area-IDE Concept-Continuous Improvement Feature - Rename Interactive-EnC
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
3 participants
@tmat @vatsalyaagrawal @jinujoseph