Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timeout on Microsoft.VisualStudio.LanguageServices.CSharp.UnitTests.dll tests #55638

Open
dibarbet opened this issue Aug 16, 2021 · 7 comments
Open
Labels

Comments

@dibarbet
Copy link
Member

dibarbet commented Aug 16, 2021

Rolling builds a relatively frequently timing out on this helix work item.

From helix log

Starting test execution, please wait...
A total of 1 test files matched the specified pattern.
[xUnit.net 00:13:35.51]     Microsoft.CodeAnalysis.Editor.CSharp.UnitTests.Interactive.Commands.InteractiveCommandHandlerTests.TestExecuteInInteractiveWithDefines [SKIP]
  Skipped Microsoft.CodeAnalysis.Editor.CSharp.UnitTests.Interactive.Commands.InteractiveCommandHandlerTests.TestExecuteInInteractiveWithDefines [1 ms]
['Microsoft.VisualStudio.LanguageServices.CSharp.UnitTests.dll' END OF WORK ITEM LOG: Command timed out, and was killed]
Build Kind Console
1814569 Rolling console.log
@dibarbet dibarbet added Test Test failures in roslyn-CI Flaky labels Aug 16, 2021
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Aug 16, 2021
@vatsalyaagrawal vatsalyaagrawal removed the untriaged Issues and PRs which have not yet been triaged by a lead label Sep 2, 2021
@vatsalyaagrawal vatsalyaagrawal added this to the 17.0 milestone Sep 2, 2021
@runfoapp runfoapp bot removed this from the 17.0 milestone Sep 21, 2021
@runfoapp runfoapp bot closed this as completed Sep 21, 2021
@dibarbet dibarbet reopened this Sep 21, 2021
@vatsalyaagrawal
Copy link
Contributor

Adding Sam's feedback: We need a heap dump at the time of timeout. We already call dotnet test so we just need to add --blame-hang to it

@JoeRobich
Copy link
Member

@jasonmalinowski
Copy link
Member

#57549 should hopefully add a dump.

@jasonmalinowski
Copy link
Member

#57549 has been merged; it's possible that runfo will no longer update this bug with hits that includes a dump, because the message has changed.

@jcouv
Copy link
Member

jcouv commented Apr 5, 2022

@allisonchou From comments above it sounds like this issue might have been fixed already. Could you confirm and close if so? Thanks

@jcouv
Copy link
Member

jcouv commented Apr 27, 2022

Chatted with Jared. He expected those helix time-outs would result in crash dumps (which we could investigate). But it looks like crash dumps are not getting produced, most likely because we run tests with a longer time-out than helix. Thread was started to clarify this time-out issue.

@jcouv
Copy link
Member

jcouv commented Apr 28, 2022

The timeout was adjusted, so hopefully we should start seeing some crash dumps for this issue.

@allisonchou allisonchou removed their assignment Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants