Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Need to unify our file system abstractions #57941

Open
jaredpar opened this issue Nov 23, 2021 · 0 comments
Open

Need to unify our file system abstractions #57941

jaredpar opened this issue Nov 23, 2021 · 0 comments
Assignees
@jaredpar
Labels
Area-Compilers Bug Concept-Design Debt Engineering Debt, Design Debt, or poor product code quality
Milestone
Backlog

Comments

@jaredpar
Copy link
Member

jaredpar commented Nov 23, 2021 •
edited
Loading

There are several file system abstractions that we use in our unit tests. We should unify them for simplicity and code hygeine:

  • TestableFileSystem
  • StrongNameFileSystem

Need to also consider TouchedFileLogger. The most correct implementation is essentially for it to sit under our file system abstraction and to essentially ban direct use of File. in MS.CA.*
@jaredpar jaredpar added Bug Area-Compilers Concept-Design Debt Engineering Debt, Design Debt, or poor product code quality labels Nov 23, 2021
@jaredpar jaredpar added this to the 17.1 milestone Nov 23, 2021
@jaredpar jaredpar self-assigned this Nov 23, 2021
@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged Issues and PRs which have not yet been triaged by a lead label Nov 23, 2021
@jaredpar jaredpar mentioned this issue Nov 23, 2021
Merged
2 tasks
@jaredpar jaredpar removed the untriaged Issues and PRs which have not yet been triaged by a lead label Jan 4, 2022
@jinujoseph jinujoseph modified the milestones: 17.1, 17.2 Mar 2, 2022
@jcouv jcouv modified the milestones: 17.2, 17.3 May 14, 2022
@jaredpar jaredpar modified the milestones: 17.3, Backlog Jun 27, 2022
@jaredpar jaredpar mentioned this issue Sep 21, 2022
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jaredpar jaredpar

Labels
Area-Compilers Bug Concept-Design Debt Engineering Debt, Design Debt, or poor product code quality
Projects
Roslyn Compiler Tech Debt
Status: No status
Milestone
Backlog
Development

No branches or pull requests
3 participants
@jaredpar @jinujoseph @jcouv